From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] iptables: Reduce code duplicity
Date: Thu, 19 Dec 2019 19:17:33 +0100 [thread overview]
Message-ID: <20191219181733.GA23391@dell5510> (raw)
In-Reply-To: <0805dbe9-e769-1073-10e0-ca42c9d06052@oracle.com>
Hi Alexey,
> Lgtm, except the removing of the variables, which were initializing
> with 0 (including cleanup_ ones). I know, it's very unlikely, but what
> if someone use the same name already elsewhere, then we get unexpected
> results for the test:
> # export use_iptables=1
> # nft01.sh
> nft01 1 TINFO: timeout per run is 0h 5m 0s
> nft01 1 TINFO: INIT: Flushing all rules
> nft01 1 TINFO: iptables -L -t filter will list all rules in table filter
> nft01 1 TINFO: iptables -L -t filter lists rules
Right, this makes sense. Thanks for review, merged with variables kept.
Kind regards,
Petr
prev parent reply other threads:[~2019-12-19 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 7:26 [LTP] [PATCH 1/1] iptables: Reduce code duplicity Petr Vorel
2019-12-19 17:37 ` Alexey Kodanev
2019-12-19 18:17 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219181733.GA23391@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox