From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH COMMITTED] tst_device: do sync() before reading test block device stat file
Date: Thu, 2 Jan 2020 09:52:36 +0800 [thread overview]
Message-ID: <20200102015236.7400-1-liwang@redhat.com> (raw)
To avoid FS deferred IO metadata/cache interferes test result, so we
do sync simply before the tst_dev_bytes_written invocation.
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Sumit Garg <sumit.garg@linaro.org>
Cc: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
testcases/kernel/syscalls/fdatasync/fdatasync03.c | 2 ++
testcases/kernel/syscalls/fsync/fsync04.c | 2 ++
testcases/kernel/syscalls/sync/sync03.c | 2 ++
testcases/kernel/syscalls/syncfs/syncfs01.c | 2 ++
4 files changed, 8 insertions(+)
diff --git a/testcases/kernel/syscalls/fdatasync/fdatasync03.c b/testcases/kernel/syscalls/fdatasync/fdatasync03.c
index ee50e75c9..032ac4b58 100644
--- a/testcases/kernel/syscalls/fdatasync/fdatasync03.c
+++ b/testcases/kernel/syscalls/fdatasync/fdatasync03.c
@@ -32,6 +32,8 @@ static void verify_fdatasync(void)
fd = SAFE_OPEN(FNAME, O_RDWR|O_CREAT, MODE);
+ sync();
+
tst_dev_bytes_written(tst_device->dev);
tst_fill_fd(fd, 0, TST_MB, FILE_SIZE_MB);
diff --git a/testcases/kernel/syscalls/fsync/fsync04.c b/testcases/kernel/syscalls/fsync/fsync04.c
index c67fc5692..3c1f45e94 100644
--- a/testcases/kernel/syscalls/fsync/fsync04.c
+++ b/testcases/kernel/syscalls/fsync/fsync04.c
@@ -32,6 +32,8 @@ static void verify_fsync(void)
fd = SAFE_OPEN(FNAME, O_RDWR|O_CREAT, MODE);
+ sync();
+
tst_dev_bytes_written(tst_device->dev);
tst_fill_fd(fd, 0, TST_MB, FILE_SIZE_MB);
diff --git a/testcases/kernel/syscalls/sync/sync03.c b/testcases/kernel/syscalls/sync/sync03.c
index a6f72d2ed..085ccfdeb 100644
--- a/testcases/kernel/syscalls/sync/sync03.c
+++ b/testcases/kernel/syscalls/sync/sync03.c
@@ -32,6 +32,8 @@ static void verify_sync(void)
fd = SAFE_OPEN(FNAME, O_RDWR|O_CREAT, MODE);
+ sync();
+
tst_dev_bytes_written(tst_device->dev);
tst_fill_fd(fd, 0, TST_MB, FILE_SIZE_MB);
diff --git a/testcases/kernel/syscalls/syncfs/syncfs01.c b/testcases/kernel/syscalls/syncfs/syncfs01.c
index 051a19ea6..3cf404450 100644
--- a/testcases/kernel/syscalls/syncfs/syncfs01.c
+++ b/testcases/kernel/syscalls/syncfs/syncfs01.c
@@ -33,6 +33,8 @@ static void verify_syncfs(void)
fd = SAFE_OPEN(FNAME, O_RDWR|O_CREAT, MODE);
+ sync();
+
tst_dev_bytes_written(tst_device->dev);
tst_fill_fd(fd, 0, TST_MB, FILE_SIZE_MB);
--
2.20.1
next reply other threads:[~2020-01-02 1:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 1:52 Li Wang [this message]
2020-01-02 2:09 ` [LTP] [PATCH COMMITTED] tst_device: do sync() before reading test block device stat file Yang Xu
2020-01-02 6:31 ` Li Wang
2020-01-02 6:46 ` Yang Xu
2020-01-03 7:25 ` Li Wang
2020-01-03 7:41 ` Yang Xu
2020-01-03 10:03 ` Yang Xu
2020-01-02 12:57 ` Cyril Hrubis
2020-01-03 7:24 ` Li Wang
2020-01-06 10:05 ` Cyril Hrubis
2020-01-06 10:35 ` Cyril Hrubis
2020-01-07 6:16 ` Li Wang
2020-01-07 6:13 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102015236.7400-1-liwang@redhat.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox