From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH COMMITTED] tst_device: do sync() before reading test block device stat file
Date: Mon, 6 Jan 2020 11:05:40 +0100 [thread overview]
Message-ID: <20200106100540.GA25027@rei.lan> (raw)
In-Reply-To: <CAEemH2fdY_pPjNCEFmcd_zsye4HAciPuhF+Fiyde9WmBci=+Lg@mail.gmail.com>
Hi!
> > > To avoid FS deferred IO metadata/cache interferes test result, so we
> > > do sync simply before the tst_dev_bytes_written invocation.
> >
> > Can we do fsync() on the fd instead of full sync()? That should be
> > slightly faster.
> >
>
> Probably you miss the previous discussed [1], we use sync() here because we
> do want to make sure all FS metadata/cache being written back before the
> testing since there is no obtainable file descriptor 'fd' for the ext4
> deferred IO (e.g. initialize the journal and inode tables).
Ah, right, we measure I/O to the whole device, so we would have to sync
the device in question. Then syncfs() on the fd we got should work
right? And it should avoid syncing unrelated filesystems as well.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-01-06 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 1:52 [LTP] [PATCH COMMITTED] tst_device: do sync() before reading test block device stat file Li Wang
2020-01-02 2:09 ` Yang Xu
2020-01-02 6:31 ` Li Wang
2020-01-02 6:46 ` Yang Xu
2020-01-03 7:25 ` Li Wang
2020-01-03 7:41 ` Yang Xu
2020-01-03 10:03 ` Yang Xu
2020-01-02 12:57 ` Cyril Hrubis
2020-01-03 7:24 ` Li Wang
2020-01-06 10:05 ` Cyril Hrubis [this message]
2020-01-06 10:35 ` Cyril Hrubis
2020-01-07 6:16 ` Li Wang
2020-01-07 6:13 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106100540.GA25027@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox