public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_device: add new tst_dev_sync
Date: Tue, 7 Jan 2020 11:11:19 +0100	[thread overview]
Message-ID: <20200107101119.GA22967@rei.lan> (raw)
In-Reply-To: <20200107071324.29492-1-liwang@redhat.com>

Hi!
>  This function reads test block device stat file (/sys/block/<device>/stat) and
> -returns the bytes written since the last invocation of this function.
> +returns the bytes written since the last invocation of this function. To avoid
> +FS deferred IO metadata/cache interferes the result, we suggest doing "syncfs"
                                 |   interfecence    |

> +before the tst_dev_bytes_written first invocation. And an inline function named
> +tst_dev_sync is created for that intention.

Other than this it looks good to me, thanks for doing this, acked.


-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2020-01-07 10:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07  7:13 [LTP] [PATCH] tst_device: add new tst_dev_sync Li Wang
2020-01-07 10:11 ` Cyril Hrubis [this message]
2020-01-08 10:46   ` Li Wang
2020-01-08 11:25     ` Petr Vorel
2020-01-08 11:30       ` Petr Vorel
2020-01-08 11:35       ` Cyril Hrubis
2020-01-08 11:39         ` Li Wang
2020-01-08 11:41           ` Cyril Hrubis
2020-01-08 11:45             ` Petr Vorel
2020-01-09  6:59               ` Li Wang
2020-01-09  8:06                 ` Petr Vorel
2020-01-09  9:49                 ` Cyril Hrubis
2020-01-09 10:10                   ` Petr Vorel
2020-01-09  7:37               ` Yang Xu
2020-01-09  8:46                 ` Petr Vorel
2020-01-09  9:56                   ` Yang Xu
2020-01-09 10:05                     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107101119.GA22967@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox