From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1 3/4] syscalls/capset03: add new EPERM error test without CAP_SETPCAP
Date: Tue, 7 Jan 2020 14:39:13 +0100 [thread overview]
Message-ID: <20200107133913.GE26408@rei.lan> (raw)
In-Reply-To: <1576577571-3668-4-git-send-email-xuyang2018.jy@cn.fujitsu.com>
Hi!
> +static void setup(void)
> +{
> + pid_t pid;
> +
> + pid = getpid();
> + header.pid = pid;
> + if (geteuid() == 0) {
> + TEST(tst_syscall(__NR_capset, &header, data));
> + if (TST_RET == -1)
> + tst_brk(TBROK | TTERRNO, "capset data failed");
> + }
Please don't do that. If tests needs root (even for a subset of the
test) just set the .needs_root flag.
> +}
> +
> +static struct tst_test test = {
> + .setup = setup,
> + .test_all = verify_capset,
> + .caps = (struct tst_cap []) {
> + TST_CAP(TST_CAP_DROP, CAP_SETPCAP),
> + {}
> + },
> +};
> --
> 2.18.0
>
>
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-01-07 13:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 10:12 [LTP] [PATCH v1 0/4] cleanup capset testcase Yang Xu
2019-12-17 10:12 ` [LTP] [PATCH v1 1/4] syscalls/capset01: Cleanup & convert to new library Yang Xu
2020-01-07 13:32 ` Cyril Hrubis
2020-01-08 2:37 ` Yang Xu
2019-12-17 10:12 ` [LTP] [PATCH v1 2/4] syscalls/capset02: " Yang Xu
2019-12-17 10:12 ` [LTP] [PATCH v1 3/4] syscalls/capset03: add new EPERM error test without CAP_SETPCAP Yang Xu
2020-01-07 13:39 ` Cyril Hrubis [this message]
2020-01-08 3:19 ` Yang Xu
2020-01-08 11:03 ` Cyril Hrubis
2020-01-09 6:17 ` Yang Xu
2020-01-09 12:41 ` Cyril Hrubis
2020-01-10 5:35 ` Yang Xu
2020-01-10 10:21 ` [LTP] [PATCH v2 1/3] syscalls/capset02: Cleanup & convert to new library Yang Xu
2020-01-10 10:21 ` [LTP] [PATCH v2 2/3] syscalls/capset03: add new EPERM error test without CAP_SETPCAP Yang Xu
2020-01-15 14:28 ` Cyril Hrubis
2020-01-10 10:21 ` [LTP] [PATCH v2 3/3] syscalls/capset04: add new EPERM error test with vfs cap support Yang Xu
2020-01-15 14:28 ` Cyril Hrubis
2020-01-10 14:30 ` [LTP] [PATCH v2 1/3] syscalls/capset02: Cleanup & convert to new library Cyril Hrubis
2020-01-13 1:31 ` Yang Xu
2020-01-15 13:43 ` Cyril Hrubis
2019-12-17 10:12 ` [LTP] [PATCH v3 4/5] syscalls/quotactl05: add project quota test for xfs filesystem Yang Xu
2019-12-17 10:16 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107133913.GE26408@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox