From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_device: add new tst_dev_sync
Date: Wed, 8 Jan 2020 12:25:37 +0100 [thread overview]
Message-ID: <20200108112537.GA22954@dell5510> (raw)
In-Reply-To: <CAEemH2fmmQ2a0EVHoqkMwMOjy5EZoiNT+02yYRz-TnWpTQ__0A@mail.gmail.com>
Hi Li, Cyril,
> > > +before the tst_dev_bytes_written first invocation. And an inline
> > function named
> > > +tst_dev_sync is created for that intention.
> > Other than this it looks good to me, thanks for doing this, acked.
> Pushed.
This broke build with -Werror=implicit-function-declaration [1]:
../include/tst_device.h:78:2: error: implicit declaration of function 'syncfs'; did you mean 'sync'? [-Werror=implicit-function-declaration]
2770 syncfs(fd);
2771 ^~~~~~
2772 sync
The problem is that syncfs() is guarded with __USE_GNU (in glibc, in musl
directly _GNU_SOURCE), so this requires to use _GNU_SOURCE (before including
first header).
Because it's in tst_device.h, we effectively need to build with -D_GNU_SOURCE.
Is that what we want? Or should we always use tst_syscall(__NR_syncfs, fd)
(without conditional check #ifndef HAVE_SYNCFS) ?
Kind regards,
Petr
[1] https://travis-ci.org/linux-test-project/ltp/jobs/634178861
next prev parent reply other threads:[~2020-01-08 11:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 7:13 [LTP] [PATCH] tst_device: add new tst_dev_sync Li Wang
2020-01-07 10:11 ` Cyril Hrubis
2020-01-08 10:46 ` Li Wang
2020-01-08 11:25 ` Petr Vorel [this message]
2020-01-08 11:30 ` Petr Vorel
2020-01-08 11:35 ` Cyril Hrubis
2020-01-08 11:39 ` Li Wang
2020-01-08 11:41 ` Cyril Hrubis
2020-01-08 11:45 ` Petr Vorel
2020-01-09 6:59 ` Li Wang
2020-01-09 8:06 ` Petr Vorel
2020-01-09 9:49 ` Cyril Hrubis
2020-01-09 10:10 ` Petr Vorel
2020-01-09 7:37 ` Yang Xu
2020-01-09 8:46 ` Petr Vorel
2020-01-09 9:56 ` Yang Xu
2020-01-09 10:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108112537.GA22954@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox