From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_device: add new tst_dev_sync
Date: Thu, 9 Jan 2020 11:10:15 +0100 [thread overview]
Message-ID: <20200109101015.GC23230@dell5510> (raw)
In-Reply-To: <20200109094916.GA31981@rei.lan>
Hi,
> > The reason why not use tst_syscall() is that involves a new compile error
> > of tst_brk, and it can not get rid of errors only via include tst_test.h
> > file.
> The problem is that the header is used both for old and new test API, so
> until we convert the rest of the oldlib testcases we can't use anything
> from the new library there.
Good point.
> We solve that in other places by ifdefs, such as:
> #ifdef TST_TEST_H__
> tst_syscall(...);
> #else
> ltp_syscall(...);
> #endif
or something like (less #ifdef/#else branches):
#ifdef TST_TEST_H__
# define TST_SYSCALL(...) tst_syscall(##__VA_ARGS__)
#else
# define TST_SYSCALL(...) ltp_syscall(##__VA_ARGS__)
#endif
Kind regards,
Petr
next prev parent reply other threads:[~2020-01-09 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 7:13 [LTP] [PATCH] tst_device: add new tst_dev_sync Li Wang
2020-01-07 10:11 ` Cyril Hrubis
2020-01-08 10:46 ` Li Wang
2020-01-08 11:25 ` Petr Vorel
2020-01-08 11:30 ` Petr Vorel
2020-01-08 11:35 ` Cyril Hrubis
2020-01-08 11:39 ` Li Wang
2020-01-08 11:41 ` Cyril Hrubis
2020-01-08 11:45 ` Petr Vorel
2020-01-09 6:59 ` Li Wang
2020-01-09 8:06 ` Petr Vorel
2020-01-09 9:49 ` Cyril Hrubis
2020-01-09 10:10 ` Petr Vorel [this message]
2020-01-09 7:37 ` Yang Xu
2020-01-09 8:46 ` Petr Vorel
2020-01-09 9:56 ` Yang Xu
2020-01-09 10:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109101015.GC23230@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox