From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] tst_dev_bytes_written: parsing /proc/diskstats instead of sys file
Date: Wed, 15 Jan 2020 11:46:27 +0100 [thread overview]
Message-ID: <20200115104627.GB24851@dell5510> (raw)
In-Reply-To: <20200110123012.GA14140@rei.lan>
Hi,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > > Maybe, I am fine with your way(I tested it). I only refer to kernel
> > > documention [1] .sysfs and proc file use the same source for the
> > > information and so should not differ. So I use fixed format as kernel
> > > function to exact. Also, I want to listen advise from Sumit.
> > TBH, I think it's just a matter of taste. I am fine with either approach.
> I dot not like that much that we generate the scanf format string on the
> fly in the version that parses /proc/diskstat.
+1
> In the end we have to merge one of them, I slightly prefer mine, but I
> do not have a strong feelings about this.
+1
If we merge Cyril's, I'd be for adding the hint about LTP_DEV (maybe as a
separate commit).
Thank you both for working on this fix.
Kind regards,
Petr
next prev parent reply other threads:[~2020-01-15 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 8:30 [LTP] [PATCH v2] tst_dev_bytes_written: parsing /proc/diskstats instead of sys file Yang Xu
2020-01-06 9:16 ` Sumit Garg
2020-01-08 13:12 ` Cyril Hrubis
2020-01-09 8:35 ` Yang Xu
2020-01-09 9:34 ` Sumit Garg
2020-01-10 12:30 ` Cyril Hrubis
2020-01-15 10:46 ` Petr Vorel [this message]
2020-01-15 10:58 ` Cyril Hrubis
2020-01-15 11:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115104627.GB24851@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox