From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] rpc01.sh: Rewrite into new shell API
Date: Tue, 28 Jan 2020 19:31:09 +0100 [thread overview]
Message-ID: <20200128183109.GA7356@dell5510> (raw)
In-Reply-To: <20200128160735.26241-2-pvorel@suse.cz>
Hi,
...
> +++ b/testcases/network/rpc/basic_tests/rpc_lib.sh
> @@ -0,0 +1,16 @@
> +#!/bin/sh
> +# Copyright (c) 2020 Petr Vorel <pvorel@suse.cz>
> +
> +. tst_net.sh
> +
> +check_portmap_rpcbind()
> +{
> + tst_res TINFO "Checking for portmap or rpcbind"
> +
> + if pgrep portmap > /dev/null; then
> + PORTMAPPER="portmap"
> + else
> + pgrep rpcbind > /dev/null && PORTMAPPER="rpcbind" || \
> + tst_brk TCONF "portmap or rpcbind is not running"
> + fi
> +}
Actually I'd just switch the order of the check (rpcbind has replaced portmap)
and print what is used.
Kind regards,
Petr
prev parent reply other threads:[~2020-01-28 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 16:07 [LTP] [PATCH 1/2] rpcinfo01.sh: Rewrite into new shell API Petr Vorel
2020-01-28 16:07 ` [LTP] [PATCH 2/2] rpc01.sh: " Petr Vorel
2020-01-28 18:31 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128183109.GA7356@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox