From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/1] ioctl, pty Add: fallback definition of struct termio
Date: Wed, 29 Jan 2020 19:15:03 +0100 [thread overview]
Message-ID: <20200129181503.GA6603@dell5510> (raw)
In-Reply-To: <20200129163127.GH22477@rei.lan>
Hi,
> > Thanks! I wonder if I should move new LTP_CHECK_TERMIO function from newly
> > created ltp-termio.m4 into already existing ltp-ioctl.m4. If we want to bother.
> > BTW we might want do consider moving simple uses of AC_CHECK_TYPES (e.g.
> > ltp-quota.m4) or AC_CHECK_MEMBERS (e.g. ltp-signal.m4, ltp-perf_event.m4)
> > into configure.ac, similarly we did for AC_CHECK_HEADERS and AC_CHECK_FUNCS
> > (to cut number of files in m4/, which just contain single line).
> > But maybe this way it's easier to track why check was done.
> I would say that either way is fine, but if you prefer having the simple
> ones in configure.ac then go for it.
OK, I kept it as it is and I'll prepare some autotools cleanup patch.
Thanks for your review.
Kind regards,
Petr
prev parent reply other threads:[~2020-01-29 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 13:27 [LTP] [PATCH v2 1/1] ioctl, pty Add: fallback definition of struct termio Petr Vorel
2020-01-29 14:53 ` Cyril Hrubis
2020-01-29 15:36 ` Petr Vorel
2020-01-29 16:31 ` Cyril Hrubis
2020-01-29 18:15 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129181503.GA6603@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox