From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/3] Allow acquiring multiple loop devices
Date: Mon, 3 Feb 2020 16:24:20 +0100 [thread overview]
Message-ID: <20200203152420.GA29586@dell5510> (raw)
In-Reply-To: <20200129144913.9889-3-mdoucha@suse.cz>
Hi Martin,
> tst_acquire_device__() currently uses a hardcoded filename so only one loop
> device can be used at a time. Allow setting arbitrary temp filename so that
> multiple different loop devices can be acquired.
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Good idea, thanks!
BTW IMHO DEV_FILE should be #define DEV_FILE "test_dev.%d.img", where %d would
be PID to fix clash when tests run in paralel (e.g. mkswap01.sh and df01.sh).
I'll send a patch tomorrow, based on this one.
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-03 15:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 14:49 [LTP] [PATCH 0/3] LVM support scripts for OpenQA Martin Doucha
2020-01-29 14:49 ` [LTP] [PATCH 1/3] Fix releasing loop devices in shell API Martin Doucha
2020-02-03 15:05 ` Petr Vorel
2020-01-29 14:49 ` [LTP] [PATCH 2/3] Allow acquiring multiple loop devices Martin Doucha
2020-02-03 15:24 ` Petr Vorel [this message]
2020-02-07 16:45 ` Cyril Hrubis
2020-02-07 17:07 ` Petr Vorel
2020-02-07 17:11 ` Cyril Hrubis
2020-02-10 15:48 ` Petr Vorel
2020-02-07 16:49 ` Cyril Hrubis
2020-01-29 14:49 ` [LTP] [PATCH 3/3] Add LVM support scripts Martin Doucha
2020-01-30 12:36 ` [LTP] [PATCH v2 " Martin Doucha
2020-01-30 14:41 ` [LTP] [PATCH v3 " Martin Doucha
2020-01-30 15:30 ` Petr Vorel
2020-02-19 9:37 ` [LTP] [PATCH v4 3/4] " Martin Doucha
2020-02-19 9:37 ` [LTP] [PATCH v4 4/4] Skip Btrfs in LVM stress tests Martin Doucha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203152420.GA29586@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox