From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v6 1/2] safe_macros: Use tst_umount() in safe_umount()
Date: Fri, 7 Feb 2020 16:24:07 +0100 [thread overview]
Message-ID: <20200207152406.GA16951@rei.lan> (raw)
In-Reply-To: <20200207144105.19947-1-pvorel@suse.cz>
Hi!
> To get retry workaround for gvfsd-trash background daemon.
>
> Suggested-by: Cyril Hrubis <chrubis@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
>
> this should be ok, but better to double check.
> Used in fsmount01.
My expectation is that retrying on EBUSY will not break anything. Jan
what do you think?
> lib/safe_macros.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/safe_macros.c b/lib/safe_macros.c
> index 41fa4ca83..deb19d2df 100644
> --- a/lib/safe_macros.c
> +++ b/lib/safe_macros.c
> @@ -772,7 +772,7 @@ int safe_umount(const char *file, const int lineno, void (*cleanup_fn)(void),
> {
> int rval;
>
> - rval = umount(target);
> + rval = tst_umount(target);
>
> if (rval == -1) {
> tst_brkm(TBROK | TERRNO, cleanup_fn,
> --
> 2.24.1
>
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-02-07 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 14:41 [LTP] [PATCH v6 1/2] safe_macros: Use tst_umount() in safe_umount() Petr Vorel
2020-02-07 14:41 ` [LTP] [PATCH v6 2/2] syscalls/fsmount01: Add test for new mount API v5.2 Petr Vorel
2020-02-16 7:32 ` Li Wang
2020-02-16 13:17 ` Petr Vorel
2020-02-17 6:48 ` Li Wang
2020-02-17 7:51 ` Petr Vorel
2020-02-17 9:16 ` Jan Stancek
2020-02-17 9:43 ` Petr Vorel
2020-02-17 7:17 ` Li Wang
2020-02-17 8:04 ` Viresh Kumar
2020-02-07 15:24 ` Cyril Hrubis [this message]
2020-02-07 15:47 ` [LTP] [PATCH v6 1/2] safe_macros: Use tst_umount() in safe_umount() Jan Stancek
2020-02-07 15:53 ` Petr Vorel
2020-02-07 15:56 ` Jan Stancek
2020-02-07 15:57 ` Cyril Hrubis
2020-02-07 16:10 ` Petr Vorel
2020-02-10 8:19 ` Jan Stancek
2020-02-10 12:44 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207152406.GA16951@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox