From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Hrubis <chrubis@suse.cz>
Date: Fri, 7 Feb 2020 16:24:07 +0100
Subject: [LTP] [PATCH v6 1/2] safe_macros: Use tst_umount() in
 safe_umount()
In-Reply-To: <20200207144105.19947-1-pvorel@suse.cz>
References: <20200207144105.19947-1-pvorel@suse.cz>
Message-ID: <20200207152406.GA16951@rei.lan>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi!
> To get retry workaround for gvfsd-trash background daemon.
> 
> Suggested-by: Cyril Hrubis <chrubis@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
> 
> this should be ok, but better to double check.
> Used in fsmount01.

My expectation is that retrying on EBUSY will not break anything. Jan
what do you think?

>  lib/safe_macros.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/safe_macros.c b/lib/safe_macros.c
> index 41fa4ca83..deb19d2df 100644
> --- a/lib/safe_macros.c
> +++ b/lib/safe_macros.c
> @@ -772,7 +772,7 @@ int safe_umount(const char *file, const int lineno, void (*cleanup_fn)(void),
>  {
>  	int rval;
>  
> -	rval = umount(target);
> +	rval = tst_umount(target);
>  
>  	if (rval == -1) {
>  		tst_brkm(TBROK | TERRNO, cleanup_fn,
> -- 
> 2.24.1
> 

-- 
Cyril Hrubis
chrubis@suse.cz