From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] tst_umount: Fail immediately when errno != EBUSY
Date: Sun, 16 Feb 2020 14:23:45 +0100 [thread overview]
Message-ID: <20200216132345.GA2718765@x230> (raw)
In-Reply-To: <CAEemH2fvK+d3V8W=sR4YtZpwmE=jq5TmS-g1TNTu+UbW2oU8CQ@mail.gmail.com>
Hi Li,
> Acked-by: Li Wang <liwang@redhat.com>
> Since we have guaranteed there is no other error besides EBUSY, maybe we
> could cancel the 'err == EBUSY' in the next if() sentences.
> Otherweise patch 1/3, 2/3 looks good.
> if (i == 0 && err == EBUSY) {
> ...
> }
+1 (fixed in prepared code to be merged).
Thanks for your review.
Kind regards,
Petr
prev parent reply other threads:[~2020-02-16 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 12:40 [LTP] [PATCH v2 1/3] tst_umount: Fail immediately when errno != EBUSY Petr Vorel
2020-02-10 12:40 ` [LTP] [PATCH v2 2/3] safe_macros: Use tst_umount() in safe_umount() Petr Vorel
2020-02-16 5:51 ` [LTP] [PATCH v2 1/3] tst_umount: Fail immediately when errno != EBUSY Li Wang
2020-02-16 13:23 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216132345.GA2718765@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox