[LTP] [PATCH 2/7] syscalls/fsopen: New tests

Viresh Kumar
2020-02-19T08:34:48Z

On 19-02-20, 09:23, Petr Vorel wrote:
> Hi Viresh,
>
> as somebody (probably Li) pointed out fsopen/fsopen01.c is similar to fsmount/fsmount01.c,
> so please during rebase drop it. BTW for this dropped test I'd use different
> approach (close fd in cleanup function and use tst_brk(TFAIL instead of
> tst_res(TBROK and goto):
>
> static void cleanup(void)
> {
> if (fd > 0)
> SAFE_CLOSE(fd);
> }
>
> ...
> if (fd == -1)
> tst_brk(TFAIL | TERRNO, "fsopen() failed");

Lets review this comment after my V2 series is posted today. It may be better to
keep separate tests.

> Also you added autotools check for functions (e.g. fsopen) during commits, but I
> move them to the first (together with lapi header).

Yeah, I already saw that. Thanks for that, you did the right thing :)

--
viresh