From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Mon, 17 Feb 2020 15:04:52 +0100 Subject: [LTP] [PATCH v7 4/4] syscalls/fsmount01: Add test for fsmount series API In-Reply-To: <20200217135205.GA25504@rei> References: <20200217084622.11199-1-pvorel@suse.cz> <20200217084622.11199-5-pvorel@suse.cz> <20200217135205.GA25504@rei> Message-ID: <20200217140452.GA32465@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi, > > + if (ismount(MNTPOINT)) { > > + tst_res(TPASS, "new mount API works"); > > + SAFE_UMOUNT(MNTPOINT); > > + is_mounted = 0; > > + } else > > + tst_res(TFAIL, "new mount API works"); > ^ > "device not mounted" ? +1. > Also LKML coding style prefers curly braces over both branches if they > are required over one of them. I'll fix this. > Other than this the patchset looks fine. + I'll add sort as a separate change. Kind regards, Petr