From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 1/2] lib: add .request_hugepages to reserve hugepage
Date: Mon, 17 Feb 2020 17:08:30 +0100 [thread overview]
Message-ID: <20200217160830.GA6482@dell5510> (raw)
In-Reply-To: <20200208092014.24824-1-liwang@redhat.com>
Hi Li,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Code looks good.
Minor issue: doc has broken formatting.
> +2.2.34 Reserving hugepages
> +^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +Many of the ltp tests need to use hugepage in their testing, this allows the
> +test can reserve hugepages from system only via .request_hugepages = xx.
> +
> +If set non-zero number of request_hugepages, test will try to reserve the
> +expected number of hugepage for testing in setup phase. If system does not
> +have enough hpage for using, it will try the best to reserve 80% available
> +number of hpages. With success test stores the reserved hugepage number in
> +'tst_hugepages. For the system without hugetlb supporting, variable
Missing ' here ^
> +'tst_hugepages' will be set to 0.
I propose these changes (+ strip this formatting from comments in C source - include/tst_test.h).
Kind regards,
Petr
diff --git doc/test-writing-guidelines.txt doc/test-writing-guidelines.txt
index b9f8d5ab0..ae9a8b040 100644
--- doc/test-writing-guidelines.txt
+++ doc/test-writing-guidelines.txt
@@ -1945,14 +1945,14 @@ For full documentation see the comments in 'include/tst_fuzzy_sync.h'.
2.2.34 Reserving hugepages
^^^^^^^^^^^^^^^^^^^^^^^^^^
-Many of the ltp tests need to use hugepage in their testing, this allows the
-test can reserve hugepages from system only via .request_hugepages = xx.
+Many of the LTP tests need to use hugepage in their testing, this allows the
+test can reserve hugepages from system only via '.request_hugepages = xx'.
-If set non-zero number of request_hugepages, test will try to reserve the
+If set non-zero number of 'request_hugepages', test will try to reserve the
expected number of hugepage for testing in setup phase. If system does not
have enough hpage for using, it will try the best to reserve 80% available
number of hpages. With success test stores the reserved hugepage number in
-'tst_hugepages. For the system without hugetlb supporting, variable
+'tst_hugepages'. For the system without hugetlb supporting, variable
'tst_hugepages' will be set to 0.
Also, we do cleanup and restore work for the hpages resetting automatically.
@@ -1977,9 +1977,12 @@ struct tst_test test = {
.request_hugepages = 2,
...
};
+[source,c]
+-------------------------------------------------------------------------------
or,
+-------------------------------------------------------------------------------
#include "tst_test.h"
static void run(void)
next prev parent reply other threads:[~2020-02-17 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 9:20 [LTP] [PATCH v4 1/2] lib: add .request_hugepages to reserve hugepage Li Wang
2020-02-08 9:20 ` [LTP] [PATCH v4 2/2] pkey01: disable hugetlb test if failed " Li Wang
2020-02-17 16:09 ` Petr Vorel
2020-02-17 16:08 ` Petr Vorel [this message]
2020-02-18 6:06 ` [LTP] [PATCH v4 1/2] lib: add .request_hugepages " Li Wang
2020-02-18 16:27 ` Cyril Hrubis
2020-02-19 4:02 ` Li Wang
2020-02-21 12:16 ` Petr Vorel
2020-02-22 3:02 ` Li Wang
2020-02-24 8:40 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217160830.GA6482@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox