From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/7] syscalls/fsopen: New tests
Date: Wed, 19 Feb 2020 09:23:59 +0100 [thread overview]
Message-ID: <20200219082359.GA21099@dell5510> (raw)
In-Reply-To: <CAEemH2caDii5LcOX7fbOcrJNY9=TL6RfEi6Y0ajybxMKNgw7ag@mail.gmail.com>
Hi Viresh,
as somebody (probably Li) pointed out fsopen/fsopen01.c is similar to fsmount/fsmount01.c,
so please during rebase drop it. BTW for this dropped test I'd use different
approach (close fd in cleanup function and use tst_brk(TFAIL instead of
tst_res(TBROK and goto):
static void cleanup(void)
{
if (fd > 0)
SAFE_CLOSE(fd);
}
...
if (fd == -1)
tst_brk(TFAIL | TERRNO, "fsopen() failed");
Also you added autotools check for functions (e.g. fsopen) during commits, but I
move them to the first (together with lapi header).
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-19 8:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 11:35 [LTP] [PATCH 0/7] Add new LTP tests related to fsmount family of syscalls Viresh Kumar
2020-02-14 11:35 ` [LTP] [PATCH 1/7] lapi/fsmount: Add definitions for fsmount related syscalls Viresh Kumar
2020-02-16 9:09 ` Li Wang
2020-02-17 8:08 ` Viresh Kumar
2020-02-14 11:35 ` [LTP] [PATCH 2/7] syscalls/fsopen: New tests Viresh Kumar
2020-02-16 10:11 ` Li Wang
2020-02-17 8:09 ` Viresh Kumar
2020-02-17 13:36 ` Cyril Hrubis
2020-02-18 1:15 ` Li Wang
2020-02-18 8:25 ` Viresh Kumar
2020-02-18 9:02 ` Li Wang
2020-02-18 9:08 ` Viresh Kumar
2020-02-19 8:23 ` Petr Vorel [this message]
2020-02-19 8:34 ` Viresh Kumar
2020-02-19 8:50 ` Petr Vorel
2020-02-19 8:51 ` Viresh Kumar
2020-02-14 11:35 ` [LTP] [PATCH 3/7] syscalls/fsconfig: " Viresh Kumar
2020-02-14 11:35 ` [LTP] [PATCH 4/7] syscalls/fsmount: " Viresh Kumar
2020-02-17 8:17 ` Li Wang
2020-02-17 8:29 ` Viresh Kumar
2020-02-17 8:54 ` Li Wang
2020-02-17 9:58 ` Petr Vorel
2020-02-17 10:28 ` Li Wang
2020-02-17 10:37 ` Li Wang
2020-02-17 11:02 ` Petr Vorel
2020-02-17 8:58 ` Petr Vorel
2020-02-14 11:35 ` [LTP] [PATCH 5/7] syscalls/move_mount: " Viresh Kumar
2020-02-14 11:35 ` [LTP] [PATCH 6/7] syscalls/fspick: " Viresh Kumar
2020-02-14 11:35 ` [LTP] [PATCH 7/7] syscalls/open_tree: " Viresh Kumar
2020-02-18 6:19 ` [LTP] [PATCH 0/7] Add new LTP tests related to fsmount family of syscalls Zorro Lang
2020-02-18 6:50 ` Li Wang
2020-02-18 6:58 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219082359.GA21099@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox