From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Add test for CVE 2017-10661
Date: Fri, 21 Feb 2020 11:19:14 +0100 [thread overview]
Message-ID: <20200221101913.GA24332@rei> (raw)
In-Reply-To: <8736b4gya0.fsf@our.domain.is.not.set>
Hi!
> > +static int fd = -1;
> > +static struct itimerspec its;
> > +static struct tst_fzsync_pair fzsync_pair;
> > +
> > +static void setup(void)
> > +{
> > + int tmp;
>
> All variables are temporary.
>
> > +
> > + tst_taint_init(TST_TAINT_W | TST_TAINT_D);
> > + fd = timerfd_create(CLOCK_REALTIME, 0);
> > +
> > + if (fd < 0) {
> > + tmp = (errno == ENOTSUP ? TCONF : TBROK) | TERRNO,
>
> Huh? This compiles?
I do not like this piece of code either, but apart from that it's
correct and works fine as far as I can tell.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2020-02-21 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 14:45 [LTP] [PATCH] Add test for CVE 2017-10661 Martin Doucha
2020-02-21 8:06 ` Richard Palethorpe
2020-02-21 10:19 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221101913.GA24332@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox