From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] syscalls/fcntl30: clean up && add more range test
Date: Fri, 21 Feb 2020 15:16:56 +0100 [thread overview]
Message-ID: <20200221141656.GA18564@rei> (raw)
In-Reply-To: <6c3adcfb-b3e4-ba8f-d084-a664145c1380@cn.fujitsu.com>
Hi!
> > Do we really need this? Looking at the kernel code the fcntl() just
> > reallocates the array that is holding the slots, so we only allocate new
> > array of struct pipe_buffer which contains a pointer for the actuall
> > page that is allocated when we _WRITE_ to the pipe.
> >
> Yes, you are right. But this case indeed fail when on low memory machine
> (4kb page size, 256/512M memory).
That's strange, I had a look at the code today again and as far as I can
tell we only check for user ulimit there.
What was the errno when the ioctl() has failed? Was it EPERM or ENOMEM?
The ENOMEM may have happened if the system overcommit was disabled and
the system was out of memory.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-02-21 14:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 9:47 [LTP] [PATCH v2 1/2] syscalls/fcntl30: clean up && add more range test Yang Xu
2020-01-22 9:47 ` [LTP] [PATCH v2 2/2] syscalls/fcntl37: add error test for fcntl with F_SETPIPE_SZ Yang Xu
2020-01-27 16:27 ` Cyril Hrubis
2020-02-05 13:50 ` Yang Xu
2020-01-27 16:20 ` [LTP] [PATCH v2 1/2] syscalls/fcntl30: clean up && add more range test Cyril Hrubis
2020-02-05 13:46 ` Yang Xu
2020-02-21 14:16 ` Cyril Hrubis [this message]
2020-02-06 6:04 ` [LTP] [PATCH v3 " Yang Xu
2020-02-06 6:04 ` [LTP] [PATCH v3 2/2] syscalls/fcntl37: add error test for fcntl with F_SETPIPE_SZ Yang Xu
2020-03-17 15:24 ` Cyril Hrubis
2020-02-21 16:03 ` [LTP] [PATCH v3 1/2] syscalls/fcntl30: clean up && add more range test Cyril Hrubis
2020-02-24 2:41 ` Yang Xu
2020-02-24 14:20 ` Cyril Hrubis
2020-02-25 10:20 ` Yang Xu
2020-02-28 9:41 ` Yang Xu
2020-03-18 11:02 ` Cyril Hrubis
2020-03-19 5:10 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221141656.GA18564@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox