From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V3 08/10] syscalls/move_mount: New tests
Date: Tue, 25 Feb 2020 14:57:09 +0100 [thread overview]
Message-ID: <20200225135709.GC62318@gacrux.arch.suse.de> (raw)
In-Reply-To: <e12560056ebc632918426194172a6cba48953d4e.1582612624.git.viresh.kumar@linaro.org>
Hi,
> + TEST(fsopen(tst_device->fs_type, 0));
> + fd = TST_RET;
Again:
TEST(fd = fsopen(tst_device->fs_type, 0));
> +
> + if (fd == -1) {
> + tst_res(TBROK | TERRNO, "fsopen() failed");
> + return;
> + }
> +
> + TEST(fsconfig(fd, FSCONFIG_SET_STRING, "source", tst_device->dev, 0));
> + if (TST_RET == -1) {
> + SAFE_CLOSE(fd);
> + tst_res(TBROK | TERRNO, "fsconfig() failed");
These should be TFAIL otherwise it 1) breaks all tests 2) does not report any
result:
move_mount02.c:37: BROK: fsopen() failed: SUCCESS (0)
tst_test.c:1051: BROK: Test 0 haven't reported results!
I'll send diff with these small fixes and if anybody complains, we could merge
whole patchset.
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-25 13:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 6:40 [LTP] [PATCH V3 00/10] Add new LTP tests related to fsmount family of syscalls Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 01/10] tst_device: Add tst_ismount() helper Viresh Kumar
2020-02-25 10:39 ` [LTP] [PATCH V4 1/10] tst_device: Add tst_is_mounted() helper Viresh Kumar
2020-02-26 5:14 ` Zorro Lang
2020-02-26 5:58 ` Yang Xu
2020-02-26 6:28 ` Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 02/10] lapi/fsmount.h: Add fsopen_supported_by_kernel() Viresh Kumar
2020-02-26 5:51 ` Zorro Lang
2020-02-25 6:40 ` [LTP] [PATCH V3 03/10] lapi/fsmount.h: Include "lapi/fcntl.h" Viresh Kumar
2020-02-26 5:51 ` Zorro Lang
2020-02-25 6:40 ` [LTP] [PATCH V3 04/10] syscalls/fsopen: New tests Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 05/10] syscalls/fsconfig: " Viresh Kumar
2020-02-25 13:46 ` Petr Vorel
2020-02-27 4:54 ` Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 06/10] syscalls/fsmount: Improve fsmount01 test Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 07/10] syscalls/fsmount: Add failure tests Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 08/10] syscalls/move_mount: New tests Viresh Kumar
2020-02-25 13:57 ` Petr Vorel [this message]
2020-02-26 2:27 ` Viresh Kumar
2020-02-26 3:34 ` Yang Xu
2020-02-26 4:34 ` Viresh Kumar
2020-02-26 7:47 ` Petr Vorel
2020-02-26 8:23 ` Viresh Kumar
2020-02-26 8:53 ` Petr Vorel
2020-02-26 8:59 ` Viresh Kumar
2020-02-26 9:20 ` Petr Vorel
2020-02-25 6:40 ` [LTP] [PATCH V3 09/10] syscalls/fspick: " Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 10/10] syscalls/open_tree: " Viresh Kumar
2020-02-25 14:25 ` Petr Vorel
2020-02-25 10:00 ` [LTP] [PATCH V3 00/10] Add new LTP tests related to fsmount family of syscalls Li Wang
2020-02-25 10:32 ` Petr Vorel
2020-02-25 10:48 ` Viresh Kumar
2020-02-25 14:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225135709.GC62318@gacrux.arch.suse.de \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox