[LTP] [PATCH V3 03/10] lapi/fsmount.h: Include "lapi/fcntl.h"

Zorro Lang
2020-02-26T05:51:33Z

On Tue, Feb 25, 2020 at 12:10:41PM +0530, Viresh Kumar wrote:
> All the files that include (and that will include it in future) are most
> probably going to need the definitions from "lapi/fcntl.h", include it
> directly instead of <fcntl.h>, which will break it for old RHL distros.
>
> Acked-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---

Good to me

> include/lapi/fsmount.h | 2 +-
> testcases/kernel/syscalls/fsmount/fsmount01.c | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h
> index a6a24904e66d..5e5eaca7e6ff 100644
> --- a/include/lapi/fsmount.h
> +++ b/include/lapi/fsmount.h
> @@ -7,12 +7,12 @@
> #ifndef FSMOUNT_H__
> #define FSMOUNT_H__
>
> -#include <fcntl.h>
> #include <sys/mount.h>
> #include <sys/syscall.h>
> #include <sys/types.h>
>
> #include "config.h"
> +#include "lapi/fcntl.h"
> #include "lapi/syscalls.h"
>
> #ifndef HAVE_FSOPEN
> diff --git a/testcases/kernel/syscalls/fsmount/fsmount01.c b/testcases/kernel/syscalls/fsmount/fsmount01.c
> index 8e29a1537334..514d3b0b38f8 100644
> --- a/testcases/kernel/syscalls/fsmount/fsmount01.c
> +++ b/testcases/kernel/syscalls/fsmount/fsmount01.c
> @@ -10,7 +10,6 @@
> #include <sys/mount.h>
>
> #include "tst_test.h"
> -#include "lapi/fcntl.h"
> #include "lapi/fsmount.h"
>
> #define MNTPOINT "newmount_point"
> --
> 2.21.0.rc0.269.g1a574e7a288b
>