From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V3 08/10] syscalls/move_mount: New tests
Date: Wed, 26 Feb 2020 09:53:03 +0100 [thread overview]
Message-ID: <20200226085303.GA30488@dell5510> (raw)
In-Reply-To: <20200226082318.eq5ozhgg2myscpqt@vireshk-i7>
Hi Viresh,
> On 26-02-20, 08:47, Petr Vorel wrote:
> > Your idea is correct, but IMHO it's not good to skip all the tests, which is
> > done due
> > tst_test.c:1051: BROK: Test 0 haven't reported results!
> > if you use tst_res(TBROK ...).
> I don't think that is the case. tst_res(TBROK, ...) shouldn't (and
> isn't for me) result in skipping of tests.
Correct, tst_res() itself doesn't exit the test. But the fact it uses TBROK
without reporting any result previously leads to tst_brk from the library:
tst_test.c:1036: BROK: Test haven't reported results!
tst_brk(TBROK, "Test %i haven't reported results!", i);
That's why I consider tst_res(TBROK problematic.
This is a separate discussion, see the patch I sent today
https://patchwork.ozlabs.org/patch/1244781/
Kind regards,
Petr
> > tst_brk(TBROK) is used for setup, where you create some resource, which is then
> > reused by all test runs, but this preparation fails.
> Right, but in my case I can't put all setup stuff in setup() callback
> and some of the setup bits stay in run() callback as well.
Sure. But as a result of it I'd personally use tst_res(TFAIL).
But maybe I'm wrong and others will correct me.
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-26 8:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 6:40 [LTP] [PATCH V3 00/10] Add new LTP tests related to fsmount family of syscalls Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 01/10] tst_device: Add tst_ismount() helper Viresh Kumar
2020-02-25 10:39 ` [LTP] [PATCH V4 1/10] tst_device: Add tst_is_mounted() helper Viresh Kumar
2020-02-26 5:14 ` Zorro Lang
2020-02-26 5:58 ` Yang Xu
2020-02-26 6:28 ` Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 02/10] lapi/fsmount.h: Add fsopen_supported_by_kernel() Viresh Kumar
2020-02-26 5:51 ` Zorro Lang
2020-02-25 6:40 ` [LTP] [PATCH V3 03/10] lapi/fsmount.h: Include "lapi/fcntl.h" Viresh Kumar
2020-02-26 5:51 ` Zorro Lang
2020-02-25 6:40 ` [LTP] [PATCH V3 04/10] syscalls/fsopen: New tests Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 05/10] syscalls/fsconfig: " Viresh Kumar
2020-02-25 13:46 ` Petr Vorel
2020-02-27 4:54 ` Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 06/10] syscalls/fsmount: Improve fsmount01 test Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 07/10] syscalls/fsmount: Add failure tests Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 08/10] syscalls/move_mount: New tests Viresh Kumar
2020-02-25 13:57 ` Petr Vorel
2020-02-26 2:27 ` Viresh Kumar
2020-02-26 3:34 ` Yang Xu
2020-02-26 4:34 ` Viresh Kumar
2020-02-26 7:47 ` Petr Vorel
2020-02-26 8:23 ` Viresh Kumar
2020-02-26 8:53 ` Petr Vorel [this message]
2020-02-26 8:59 ` Viresh Kumar
2020-02-26 9:20 ` Petr Vorel
2020-02-25 6:40 ` [LTP] [PATCH V3 09/10] syscalls/fspick: " Viresh Kumar
2020-02-25 6:40 ` [LTP] [PATCH V3 10/10] syscalls/open_tree: " Viresh Kumar
2020-02-25 14:25 ` Petr Vorel
2020-02-25 10:00 ` [LTP] [PATCH V3 00/10] Add new LTP tests related to fsmount family of syscalls Li Wang
2020-02-25 10:32 ` Petr Vorel
2020-02-25 10:48 ` Viresh Kumar
2020-02-25 14:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226085303.GA30488@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox