From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] request_key04: Use TFAIL instead of TBROK
Date: Wed, 26 Feb 2020 12:37:57 +0100 [thread overview]
Message-ID: <20200226113757.GA24342@dell5510> (raw)
In-Reply-To: <CAEemH2cXGOh=MX28kYvhFaHspHGXiVdGuNZeyN97+O3+bt1jGg@mail.gmail.com>
Hi Li,
> > ...
> > > > obvious fix which I'd normally merge without sending to ML.
> > > > But there are 19 tests which use tst_res(TBROK, and at least some of
> > > > them are affected by this (i.e. don't unconditionally report any result
> > > > before tst_res(TBROK), so we might want to fix it different way.
> > > +1 for this fix.
> > Thanks for your review.
> > > By the way, do you think it makes sense to add build check parameters for
> > > tst_res() too? Just like what we do for tst_brk() in commit 0738e3753c51.
> > IMHO if we agree that tst_res(TBROK) is harmful and should be avoided
> > entirely,
> I agree.
> > I'd be for adding this check.
> In personally, I'd let tst_res() only accept 'TPASS, TFAIL, TINFO, TCONF,
> TWARN'.
+1. Cyril, Jan?
Kind regards,
Petr
next prev parent reply other threads:[~2020-02-26 11:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 8:42 [LTP] [PATCH 1/1] request_key04: Use TFAIL instead of TBROK Petr Vorel
2020-02-26 9:00 ` Li Wang
2020-02-26 9:18 ` Petr Vorel
2020-02-26 9:50 ` Li Wang
2020-02-26 11:37 ` Petr Vorel [this message]
2020-02-26 12:04 ` Xiao Yang
2020-02-26 12:48 ` Cyril Hrubis
2020-02-26 13:23 ` Jan Stancek
2020-02-26 14:02 ` Petr Vorel
2020-02-26 9:22 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226113757.GA24342@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox