[LTP] [PATCH 2/4] lib: Check also flags for tst_res()

[Petr Vorel <pvorel@suse.cz>]

Hi,

> > >  #define TST_BRK_SUPPORTS_ONLY_TCONF_TBROK(condition) \
> > >         do { ((void)sizeof(char[1 - 2 * !!(condition)])); } while (0)

> > > +#define TST_RES_SUPPORTS_TCONF_TFAIL_TINFO_TPASS_TWARN(condition) \
> > > +       TST_BRK_SUPPORTS_ONLY_TCONF_TBROK(condition)


> > To be honest, this looks verbose and confusing a little. I'm thinking can
> > we just add a prefix TST_ to the kernel macro and use it directly?

> > e.g

> > #define TST_BUILD_BUG_ON(condition) \
> >         do { ((void)sizeof(char[1 - 2 * !!(condition)])); } while (0)

> I guess that the confusing part is that TST_RES_SUPPORTS_... uses
> TST_BRK_SUPPORTS_...

> I guess that it would be nicer if we had TST_BUILD_BUG_ON() and then
> both TST_RES_SUPPORTS_... and TST_BRK_SUPPORTS_... would use it.

> I personally think that TST_BUILD_BUG_ON() itself is not verbose enough
> though.

+1. I'll implement it like this and merge (unless somebody objects).

Kind regards,
Petr