From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] lib: Add safe timerfd macros
Date: Thu, 5 Mar 2020 11:11:23 +0100 [thread overview]
Message-ID: <20200305101122.GA31652@rei> (raw)
In-Reply-To: <20200304164521.GA5603@dell5510>
Hi!
> > I forgot to add one more thing: making the return value checks more
> > pedantic would also be nice.
> I guess you mean if (rval == -1). Sure, I'll do that.
Actually for the sake of SAFE_MACROS() it makes sense to fail unless we
got a valid result. So for > 0 for timerfd_create() and != 0 for
timerfd_settime() and timerfd_gettime().
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-03-05 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 15:12 [LTP] [PATCH 1/2] lib: Add safe timerfd macros Petr Vorel
2020-03-04 15:12 ` [LTP] [PATCH 2/2] timerfd: Use safe macros Petr Vorel
2020-03-04 16:03 ` Martin Doucha
2020-03-04 15:22 ` [LTP] [PATCH 1/2] lib: Add safe timerfd macros Cyril Hrubis
2020-03-04 15:56 ` Martin Doucha
2020-03-04 16:02 ` Martin Doucha
2020-03-04 16:45 ` Petr Vorel
2020-03-05 10:11 ` Cyril Hrubis [this message]
2020-03-05 11:54 ` Petr Vorel
2020-03-05 12:21 ` Petr Vorel
2020-03-04 16:03 ` Cyril Hrubis
2020-03-04 16:04 ` Cyril Hrubis
2020-03-04 16:49 ` Petr Vorel
2020-03-04 16:28 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2020-03-04 18:38 Petr Vorel
2020-03-04 18:49 ` Petr Vorel
2020-03-05 10:28 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305101122.GA31652@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox