From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] Add TST_ASSERT_SYSCALL*() macros
Date: Thu, 5 Mar 2020 18:53:25 +0100 [thread overview]
Message-ID: <20200305175325.GA16171@rei> (raw)
In-Reply-To: <20200305174205.GA29517@dell5510>
Hi!
> What I like on these macros (besides DRY) is that it really shows the test, not
> the library, see
> before:
> tst_safe_timerfd.c:21: BROK: timerfd01.c:89 timerfd_create(CLOCK_MONOTONIC) failed: EINVAL (22)
> after:
> timerfd01.c:89: BROK: timerfd_create(CLOCK_MONOTONIC) failed: EINVAL (22)
That's because it calls tst_brk_() correctly instead of tst_brk(). I
should have caught that during the review.
Also given the way it's structured now we can pass these parameters to a
shell script as well and generate the end result easily. With a bit more
work we can generate both header and C source as well and would still
prefer that over these macros.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-03-05 17:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 15:14 [LTP] [PATCH v2 1/2] Add TST_ASSERT_SYSCALL*() macros Martin Doucha
2020-03-05 15:14 ` [LTP] [PATCH v2 2/2] Reimplement TST_SAFE_TIMERFD_*() using TST_ASSERT_SYSCALL*() Martin Doucha
2020-03-05 15:20 ` Cyril Hrubis
2020-03-05 17:50 ` Petr Vorel
2020-03-05 17:42 ` [LTP] [PATCH v2 1/2] Add TST_ASSERT_SYSCALL*() macros Petr Vorel
2020-03-05 17:53 ` Cyril Hrubis [this message]
2020-03-05 19:36 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305175325.GA16171@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox