From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] hugeshmctl01: Small refactor and remove stat_time
Date: Fri, 6 Mar 2020 12:02:06 +0100 [thread overview]
Message-ID: <20200306110206.GA14696@dell5510> (raw)
In-Reply-To: <1583490720-10003-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>
Hi Xu,
nice cleanup & refactoring, thanks!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> @@ -154,6 +155,7 @@ static void stat_setup(void)
> }
> }
> +
nit: this is extra new line (whoever merges this, please remove it).
> /*
> * func_stat() - check the functionality of the IPC_STAT command with shmctl()
> * by looking at the pid of the creator, the segement size,
Kind regards,
Petr
next prev parent reply other threads:[~2020-03-06 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 9:53 [LTP] [PATCH] hugeshmctl01: Revert "hugeshmctl: Use loop from the API" Yang Xu
2020-03-05 17:21 ` Petr Vorel
2020-03-06 6:11 ` Li Wang
2020-03-06 7:12 ` Petr Vorel
2020-03-06 8:03 ` Yang Xu
2020-03-06 10:32 ` [LTP] [PATCH v2] hugeshmctl01: Small refactor and remove stat_time Yang Xu
2020-03-06 11:02 ` Petr Vorel [this message]
2020-03-06 12:36 ` Li Wang
2020-03-09 3:57 ` Yang Xu
2020-03-09 4:56 ` Petr Vorel
2020-03-09 6:04 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306110206.GA14696@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox