From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Hrubis <chrubis@suse.cz>
Date: Mon, 9 Mar 2020 11:34:00 +0100
Subject: [LTP] [PATCH 2/8] lapi: Add a configure check and fallback for
 setns
In-Reply-To: <20200309101533.GA355713@x230>
References: <20200305134834.16736-1-chrubis@suse.cz>
 <20200305134834.16736-3-chrubis@suse.cz>
 <20200309101533.GA355713@x230>
Message-ID: <20200309103359.GA29747@rei.lan>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it

Hi!
> There is an error for old glibc on centos 06:
> 
> https://api.travis-ci.org/v3/job/659994070/log.txt
> 
> In file included from /usr/src/ltp/testcases/kernel/syscalls/clock_gettime/clock_gettime03.c:21:
> 
> /usr/src/ltp/include/lapi/setns.h: In function 'setns':
> 
> /usr/src/ltp/include/lapi/setns.h:16: error: implicit declaration of function 'syscall'

Hmm, I guess that we can include unistd.h in the lapi/syscalls.h so that
the syscall() function has a prototype.

> /usr/src/ltp/include/lapi/setns.h:16: error: implicit declaration of function 'tst_brk'
> 
> /usr/src/ltp/include/lapi/setns.h:16: error: 'TCONF' undeclared (first use in this function)
> 
> /usr/src/ltp/include/lapi/setns.h:16: error: (Each undeclared identifier is reported only once
> 
> /usr/src/ltp/include/lapi/setns.h:16: error: for each function it appears in.)
> 
> In file included from /usr/src/ltp/include/tst_test.h:14,
> 
>                  from /usr/src/ltp/include/tst_safe_clocks.h:13,
> 
>                  from /usr/src/ltp/testcases/kernel/syscalls/clock_gettime/clock_gettime03.c:22:

Okay, I guess that both errors could be fixed by moving the lapi/setns.h
include after the tst_test.h in the test, because tst_test.h both
includes unistd.h as well as defines the tst_brk() and TCONF.

Thanks for spotting this.

-- 
Cyril Hrubis
chrubis@suse.cz