From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/8] syscalls/sysinfo03: Add time namespace test
Date: Mon, 9 Mar 2020 14:33:02 +0100 [thread overview]
Message-ID: <20200309133301.GC29747@rei.lan> (raw)
In-Reply-To: <87h7yxfylj.fsf@our.domain.is.not.set>
Hi!
> >> > +static struct tst_test test = {
> >> > + .tcnt = ARRAY_SIZE(offsets),
> >> > + .test = verify_sysinfo,
> >> > + .needs_root = 1,
> >> > + .forks_child = 1,
> >> > + .needs_kconfigs = (const char *[]) {
> >> > + "CONFIG_TIME_NS=y"
> >> > + }
> >> > +};
> >>
> >> Will you add a git ref when the fix is in mainline/for-next?
> >>
> >> Should be safe to add it as soon as it is in the for-next tree.
> >
> > I'm not sure how usefull that will be because the fix should get in
> > during the RC phase the functionality was introduced, so technically the
> > missing support of sysinfo() in time namespaces should not reach any
> > officially released kernel.
>
> What is the downside to including it?
>
> Also, I can imagine some people will try backporting this and may miss
> something not in the original patch set.
Okay, that's a valid reason to include the hash.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-03-09 13:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 13:48 [LTP] [PATCH 0/8] Add basic time namespace testcases Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 1/8] lapi/namespace_constants.h: Add CLONE_NEWTIME Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 2/8] lapi: Add a configure check and fallback for setns Cyril Hrubis
2020-03-09 10:15 ` Petr Vorel
2020-03-09 10:34 ` Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 3/8] include/tst_timer: Fix normalization Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 4/8] syscalls/sysinfo03: Add time namespace test Cyril Hrubis
2020-03-09 12:32 ` Richard Palethorpe
2020-03-09 12:48 ` Cyril Hrubis
2020-03-09 13:26 ` Richard Palethorpe
2020-03-09 13:33 ` Cyril Hrubis [this message]
2020-03-05 13:48 ` [LTP] [PATCH 5/8] syscalls/clock_nanosleep03: Add test for time namespace Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 6/8] syscalls/clock_gettime03: Add basic time namespace test Cyril Hrubis
2020-03-09 13:23 ` Richard Palethorpe
2020-03-09 13:49 ` Cyril Hrubis
2020-03-05 13:48 ` [LTP] [PATCH 7/8] containers/timens: Add basic error test Cyril Hrubis
2020-03-10 12:06 ` Richard Palethorpe
2020-03-05 13:48 ` [LTP] [PATCH 8/8] syscalls/timerfd04: Add time namespace test Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309133301.GC29747@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox