[LTP] [PATCH v3 1/3] Create separate .c file for include/tst_net.h

Cyril Hrubis
2020-03-16T14:18:42Z

Hi!
> >> +int tst_bit_count(uint32_t i);
> >> +int tst_mask2prefix(struct in_addr mask);
> >> +int tst_ipv4_mask_to_int(const char *prefix);
> >> +int tst_safe_atoi(const char *s, int *ret_i);
> >> +int tst_get_prefix(const char *ip_str, int is_ipv6);
> >> +void tst_get_in_addr(const char *ip_str, struct in_addr *ip);
> >> +void tst_get_in6_addr(const char *ip_str, struct in6_addr *ip6);
> >
> > Do we need all of these exported in the public API?
> >
> > It looks to me like most of these shouldn't be exported at all.
>
> I guess that's a question for Petr. I'll be happy to drop the functions
> meant to be private from the .h file and make them static in the .c file.

Let's do that, there is no point in exporting unused functions.

--
Cyril Hrubis
chrubis@suse.cz