From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCHv2 1/3] zram/zram_lib.sh: fix variable name and algorithm retrieval
Date: Tue, 17 Mar 2020 18:44:27 +0100 [thread overview]
Message-ID: <20200317174427.GA11295@dell5510> (raw)
In-Reply-To: <CAMy_GT9VC5KvgCL68fVXVfKwErwKqiNab0s8SwPw9BZxMuLReg@mail.gmail.com>
Hi Po-Hsu,
> thanks for the reply, and sorry for the late response too, need some
> time to throw myself back in time.
> To my understanding, the zram_algs="lzo lzo lzo lzo" in zram01.sh is a
> dummy mapping (placeholder?) for 4 compression algorithms with 4
> different setup, one for (zram_sizes=26214400, zram_mem_limits=25M,
> zram_filesystems=ext3), and one for (zram_sizes=26214400,
> zram_mem_limits=25M, zram_filesystems=ext4) and so on.
> With this patch the test will be more comprehensive, as it's not
> trying to set the algorithm to "lzo" 4 times (as defined in zram_algs
> from zram01.sh), but try to switch to all supported algorithm reported
> back from /sys/block/zram0/comp_algorithm
> So yes, this zram_algs in zram01.sh will not be used at all after
> applying my patch here, maybe it can be removed but I am not sure if
> we should keep it there as a placeholder.
Also sorry for the delay. I rebased and merged these 2 commits, removed
$zram_algs (as it's was not used any more).
Although this and second commit should be probably as a single commit (to be an
atomic change), I kept them separate.
Thanks for your contributions.
Kind regards,
Petr
next prev parent reply other threads:[~2020-03-17 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 7:23 [LTP] [PATCHv2 0/3] zram/zram_lib.sh: fix zram_compress_alg() test for zram01 Po-Hsu Lin
2019-07-10 7:23 ` [LTP] [PATCHv2 1/3] zram/zram_lib.sh: fix variable name and algorithm retrieval Po-Hsu Lin
2020-02-21 5:59 ` Petr Vorel
2020-03-02 7:12 ` Po-Hsu Lin
2020-03-17 17:44 ` Petr Vorel [this message]
2019-07-10 7:23 ` [LTP] [PATCHv2 2/3] zram/zram_lib.sh: iterate through all available compression algorithms for all zram block devices Po-Hsu Lin
2019-07-10 7:23 ` [LTP] [PATCH 3/3] zram/zram_lib.sh: set the compression algorithms back to default after test Po-Hsu Lin
2020-03-17 18:21 ` Petr Vorel
2020-03-19 14:39 ` Po-Hsu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317174427.GA11295@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox