public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V6 05/10] syscalls/fsconfig: New tests
Date: Tue, 17 Mar 2020 22:33:38 +0100	[thread overview]
Message-ID: <20200317213338.GB4871@dell5510> (raw)
In-Reply-To: <824c287cd06190cf0a489535fd4617aff8742b03.1584014172.git.viresh.kumar@linaro.org>

Hi Viresh,

> +	TEST(fd = fsopen(tst_device->fs_type, 0));
> +	if (fd == -1)
> +		tst_brk(TBROK | TERRNO, "fsopen() failed");
Just a note all these tst_brk/tst_res after TEST() should use TTERRNO, not TERRNO.
Although TERRNO will probably work in this case as well, it'd be better to use
TTERRNO (see lib/tst_res.c).

Kind regards,
Petr

  parent reply	other threads:[~2020-03-17 21:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12 12:01 [LTP] [PATCH V6 00/10] Add new LTP tests related to fsmount family of syscalls Viresh Kumar
2020-03-12 12:01 ` [LTP] [PATCH V6 01/10] tst_device: Add tst_is_mounted() and tst_is_mounted_at_tmpdir() helpers Viresh Kumar
2020-03-12 12:01 ` [LTP] [PATCH V6 02/10] lapi/fsmount.h: Add fsopen_supported_by_kernel() Viresh Kumar
2020-03-12 12:01 ` [LTP] [PATCH V6 03/10] lapi/fsmount.h: Include "lapi/fcntl.h" Viresh Kumar
2020-03-12 12:01 ` [LTP] [PATCH V6 04/10] syscalls/fsopen: New tests Viresh Kumar
2020-03-12 12:01 ` [LTP] [PATCH V6 05/10] syscalls/fsconfig: " Viresh Kumar
2020-03-12 19:10   ` Cyril Hrubis
2020-03-13  4:00     ` Viresh Kumar
2020-03-13  7:22       ` Petr Vorel
2020-03-13  8:03       ` Cyril Hrubis
2020-03-13  8:48         ` Viresh Kumar
2020-03-13 12:09           ` Petr Vorel
2020-03-16  6:09             ` Viresh Kumar
2020-03-16  6:22               ` Petr Vorel
2020-03-17 21:33   ` Petr Vorel [this message]
2020-03-12 12:01 ` [LTP] [PATCH V6 06/10] syscalls/fsmount: Improve fsmount01 test Viresh Kumar
2020-03-12 12:01 ` [LTP] [PATCH V6 07/10] syscalls/fsmount: Add failure tests Viresh Kumar
2020-03-12 12:01 ` [LTP] [PATCH V6 08/10] syscalls/move_mount: New tests Viresh Kumar
2020-03-12 19:07   ` Cyril Hrubis
2020-03-12 12:01 ` [LTP] [PATCH V6 09/10] syscalls/fspick: " Viresh Kumar
2020-03-13  7:04   ` Petr Vorel
2020-03-13 12:35   ` Cyril Hrubis
2020-03-12 12:01 ` [LTP] [PATCH V6 10/10] syscalls/open_tree: " Viresh Kumar
2020-03-13  8:48   ` Petr Vorel
2020-03-13  9:03   ` [LTP] [PATCH V7 " Viresh Kumar
2020-03-13 12:27     ` Petr Vorel
2020-03-13 12:49     ` Cyril Hrubis
2020-03-13 12:50       ` Petr Vorel
2020-03-20  4:35       ` Viresh Kumar
2020-03-20 19:59         ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317213338.GB4871@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox