From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 1/2] syscalls/fcntl30: clean up && add more range test
Date: Wed, 18 Mar 2020 12:02:12 +0100 [thread overview]
Message-ID: <20200318110212.GA1690@haruka.lan> (raw)
In-Reply-To: <9e73a02e-7169-7229-8bc0-2ac84129bf31@cn.fujitsu.com>
Hi!
> Ping.
> diff as below:
> diff --git a/testcases/kernel/syscalls/fcntl/fcntl30.c
> b/testcases/kernel/syscalls/fcntl/fcntl30.c
> index 860d42e8d..28cdee165 100644
> --- a/testcases/kernel/syscalls/fcntl/fcntl30.c
> +++ b/testcases/kernel/syscalls/fcntl/fcntl30.c
> @@ -31,8 +31,7 @@ static struct tcase {
> {0, 0, 0, 1, "set a value of below page size"},
> {0, 0, 0, 1, "set a normal value"},
> {0, 0, 1, 1, "set a value of below page size"},
> - {0, 0, 1, 1, "set a normal value"},
> - {0, 0, 1, 1, "set a max value"},
> + {0, 0, 1, 1, "set a normal value(8M)"},
> {0, 0, 1, 0, "set a value beyond max"},
> };
>
> @@ -145,13 +144,10 @@ static void setup(void)
> tcases[2].setsize = (1 << pg_shift) - 1;
> tcases[2].expsize = 1 << pg_shift;
>
> - tcases[3].setsize = 2 << pg_shift;
> - tcases[3].expsize = 2 << pg_shift;
> + tcases[3].setsize = 1 << 23;
> + tcases[3].expsize = 1 << 23;
>
> - tcases[4].setsize = 1 << shift;
> - tcases[4].expsize = 1 << shift;
> -
> - tcases[5].setsize = (1 << shift) + 1;
> + tcases[4].setsize = (1 << shift) + 1;
>
> pw = SAFE_GETPWNAM("nobody");
> }
Do we have to keep the shift in here?
Given that we are not aiming at a precise value now, we should be fine
as long as we request the buffer to be a few megabytes in lenght and we
can drop all the arch specific code from here, right?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-03-18 11:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 9:47 [LTP] [PATCH v2 1/2] syscalls/fcntl30: clean up && add more range test Yang Xu
2020-01-22 9:47 ` [LTP] [PATCH v2 2/2] syscalls/fcntl37: add error test for fcntl with F_SETPIPE_SZ Yang Xu
2020-01-27 16:27 ` Cyril Hrubis
2020-02-05 13:50 ` Yang Xu
2020-01-27 16:20 ` [LTP] [PATCH v2 1/2] syscalls/fcntl30: clean up && add more range test Cyril Hrubis
2020-02-05 13:46 ` Yang Xu
2020-02-21 14:16 ` Cyril Hrubis
2020-02-06 6:04 ` [LTP] [PATCH v3 " Yang Xu
2020-02-06 6:04 ` [LTP] [PATCH v3 2/2] syscalls/fcntl37: add error test for fcntl with F_SETPIPE_SZ Yang Xu
2020-03-17 15:24 ` Cyril Hrubis
2020-02-21 16:03 ` [LTP] [PATCH v3 1/2] syscalls/fcntl30: clean up && add more range test Cyril Hrubis
2020-02-24 2:41 ` Yang Xu
2020-02-24 14:20 ` Cyril Hrubis
2020-02-25 10:20 ` Yang Xu
2020-02-28 9:41 ` Yang Xu
2020-03-18 11:02 ` Cyril Hrubis [this message]
2020-03-19 5:10 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318110212.GA1690@haruka.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox