[LTP] [PATCH v2 5/9] syscalls/sysinfo03: Add time namespace test

Cyril Hrubis
2020-03-19T22:00:06Z

Hi!
> > +static struct tst_test test = {
> > + .tcnt = ARRAY_SIZE(offsets),
> > + .test = verify_sysinfo,
> > + .needs_root = 1,
> > + .forks_child = 1,
> > + .needs_kconfigs = (const char *[]) {
> > + "CONFIG_TIME_NS=y"
> >
>
> Shouldn't end with 'NULL' in kconfig struct?
> If not that will mislead arrary_len to recognise wrong number of arrry(cnt)
> and caused segmentation fault in test.
>
>
>
> > + }
> >
>
> A comma is required here ^, otherwise it'd be failing in the build phase.
>
> + .tags = (const struct tst_tag[]) {
> > + {"linux-git", "ecc421e05bab"},
> >
>
> Ending with '{}' in tags struct?

Of course, thanks for catching that!

I will fix these before applying, if the patchset is acked otherwise.

--
Cyril Hrubis
chrubis@suse.cz