* [LTP] [PATCH] syscalls/fspick: Call fsconfig with FSCONFIG_CMD_RECONFIGURE @ 2020-03-20 4:52 Viresh Kumar 2020-03-20 12:04 ` Petr Vorel 0 siblings, 1 reply; 3+ messages in thread From: Viresh Kumar @ 2020-03-20 4:52 UTC (permalink / raw) To: ltp Make sure mountpoint is reconfigured after all the recent changes by calling fsconfig() with FSCONFIG_CMD_RECONFIGURE. Suggested-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- testcases/kernel/syscalls/fspick/fspick01.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/testcases/kernel/syscalls/fspick/fspick01.c b/testcases/kernel/syscalls/fspick/fspick01.c index 3b3635b20195..b5a35bf61e2c 100644 --- a/testcases/kernel/syscalls/fspick/fspick01.c +++ b/testcases/kernel/syscalls/fspick/fspick01.c @@ -43,6 +43,12 @@ static void run(unsigned int n) goto out; } + TEST(fsconfig(fspick_fd, FSCONFIG_CMD_RECONFIGURE, NULL, NULL, 0)); + if (TST_RET == -1) { + tst_res(TFAIL | TTERRNO, "fsconfig() failed"); + goto out; + } + tst_res(TPASS, "%s: fspick() passed", tc->name); out: -- 2.21.0.rc0.269.g1a574e7a288b ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH] syscalls/fspick: Call fsconfig with FSCONFIG_CMD_RECONFIGURE 2020-03-20 4:52 [LTP] [PATCH] syscalls/fspick: Call fsconfig with FSCONFIG_CMD_RECONFIGURE Viresh Kumar @ 2020-03-20 12:04 ` Petr Vorel 2020-03-23 3:14 ` Viresh Kumar 0 siblings, 1 reply; 3+ messages in thread From: Petr Vorel @ 2020-03-20 12:04 UTC (permalink / raw) To: ltp Hi Viresh, > Make sure mountpoint is reconfigured after all the recent changes by > calling fsconfig() with FSCONFIG_CMD_RECONFIGURE. Thanks, merged. BTW how about print flag on failure? (just to improve readability, although there are line numbers so not required). Kind regards, Petr diff --git testcases/kernel/syscalls/fspick/fspick01.c testcases/kernel/syscalls/fspick/fspick01.c index b5a35bf61..c84723805 100644 --- testcases/kernel/syscalls/fspick/fspick01.c +++ testcases/kernel/syscalls/fspick/fspick01.c @@ -33,19 +33,19 @@ static void run(unsigned int n) TEST(fsconfig(fspick_fd, FSCONFIG_SET_STRING, "sync", "false", 0)); if (TST_RET == -1) { - tst_res(TFAIL | TTERRNO, "fsconfig() failed"); + tst_res(TFAIL | TTERRNO, "fsconfig(FSCONFIG_SET_STRING) failed"); goto out; } TEST(fsconfig(fspick_fd, FSCONFIG_SET_FLAG, "ro", NULL, 0)); if (TST_RET == -1) { - tst_res(TFAIL | TTERRNO, "fsconfig() failed"); + tst_res(TFAIL | TTERRNO, "fsconfig(FSCONFIG_SET_FLAG) failed"); goto out; } TEST(fsconfig(fspick_fd, FSCONFIG_CMD_RECONFIGURE, NULL, NULL, 0)); if (TST_RET == -1) { - tst_res(TFAIL | TTERRNO, "fsconfig() failed"); + tst_res(TFAIL | TTERRNO, "fsconfig(FSCONFIG_CMD_RECONFIGURE) failed"); goto out; } ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH] syscalls/fspick: Call fsconfig with FSCONFIG_CMD_RECONFIGURE 2020-03-20 12:04 ` Petr Vorel @ 2020-03-23 3:14 ` Viresh Kumar 0 siblings, 0 replies; 3+ messages in thread From: Viresh Kumar @ 2020-03-23 3:14 UTC (permalink / raw) To: ltp On 20-03-20, 13:04, Petr Vorel wrote: > Hi Viresh, > > > Make sure mountpoint is reconfigured after all the recent changes by > > calling fsconfig() with FSCONFIG_CMD_RECONFIGURE. > > Thanks, merged. > > BTW how about print flag on failure? (just to improve readability, although > there are line numbers so not required). Yeah, I have been relying on line numbers mostly for this. Though I can add more descriptive messages if you want :) -- viresh ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-23 3:14 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-20 4:52 [LTP] [PATCH] syscalls/fspick: Call fsconfig with FSCONFIG_CMD_RECONFIGURE Viresh Kumar 2020-03-20 12:04 ` Petr Vorel 2020-03-23 3:14 ` Viresh Kumar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox