From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] lib: Implement SAFE_RUN() macro (new API only)
Date: Mon, 23 Mar 2020 10:20:14 +0100 [thread overview]
Message-ID: <20200323092014.GA26702@dell5510> (raw)
In-Reply-To: <edd8ed18-8cb3-2a13-7caa-a55c3447389a@cn.fujitsu.com>
Hi Xu,
> > + tst_brk(TBROK, "%s:%d: %s failed (%d)", file, lineno, rc);
> typo, rc -> rval and miss argv[0].
> > + }
> > +}
> > +#define SAFE_RUNCMD(argv, stdout_path, stderr_path) \
> > + safe_run_cmd(__FILE__, __LINE__, NULL, (argv), (stdout_path), (stderr_path))
> I guess we don't need the third argument(NULL).
Thanks for catching these! I've sent v2 with your Reviewed-by: tag.
Kind regards,
Petr
prev parent reply other threads:[~2020-03-23 9:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 13:49 [LTP] [PATCH 1/2] lib: Implement SAFE_RUN() macro (new API only) Petr Vorel
2020-03-20 13:49 ` [LTP] [PATCH 2/2] Use SAFE_RUNCMD() Petr Vorel
2020-03-23 3:13 ` Yang Xu
2020-03-23 9:04 ` Petr Vorel
2020-03-23 9:10 ` Li Wang
2020-03-23 9:52 ` Yang Xu
2020-03-23 11:37 ` Petr Vorel
2020-03-23 13:42 ` Li Wang
2020-03-23 14:32 ` Li Wang
2020-03-23 16:04 ` Petr Vorel
2020-03-24 23:51 ` Cyril Hrubis
2020-03-24 17:21 ` Petr Vorel
2020-03-25 1:53 ` Cyril Hrubis
2020-03-24 18:55 ` Petr Vorel
2020-03-25 5:56 ` Li Wang
2020-03-25 5:30 ` Li Wang
2020-03-25 17:07 ` Cyril Hrubis
2020-03-25 9:34 ` Petr Vorel
2020-03-25 10:03 ` Cyril Hrubis
2020-03-25 15:40 ` Petr Vorel
2020-03-25 10:42 ` Yang Xu
2020-03-25 15:56 ` Petr Vorel
2020-03-26 5:27 ` Li Wang
2020-03-26 8:03 ` Yang Xu
2020-03-23 15:49 ` Petr Vorel
2020-03-24 6:27 ` Li Wang
2020-03-23 2:43 ` [LTP] [PATCH 1/2] lib: Implement SAFE_RUN() macro (new API only) Yang Xu
2020-03-23 9:20 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323092014.GA26702@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox