From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Tue, 24 Mar 2020 18:21:02 +0100 Subject: [LTP] [PATCH 2/2] Use SAFE_RUNCMD() In-Reply-To: <20200324235150.GC4521@yuki.lan> References: <20200320134937.16616-1-pvorel@suse.cz> <20200320134937.16616-2-pvorel@suse.cz> <303d1019-f836-b2ae-ce51-d2c46dd7fb1e@cn.fujitsu.com> <20200323113738.GA4807@dell5510> <20200323160415.GC15673@dell5510> <20200324235150.GC4521@yuki.lan> Message-ID: <20200324172102.GA1307@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Cyril, ... > We already do have tst_get_path() that does more or less the same. Thanks for info! > Also if we are going to add this functionality it should be added as an > .needs_cmds array in the tst_test structure. .needs_cmds sounds as a good idea. But let's do it as a separate effort. I'll leave already sent v2 for review. Once .needs_cmds is implemented, we can use it as well for copy_file_range02.c. BTW what do you think on changing 255 (and 254) for something less common? It's just a corner case swapon on certain setup in copy_file_range02.c returns 255 on error: Setting up swapspace version 1, size = 36 KiB (36864 bytes) no label, UUID=bae78639-be0b-42b2-9e91-815b05f5751b swapon: /tmp/msT4Ch/file_swap: swapon failed: Invalid argument copy_file_range02.c:95: CONF: swapon binary not installed or failed Kind regards, Petr