From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/3] accept4: Use tst_variant
Date: Wed, 25 Mar 2020 00:35:51 +0100 [thread overview]
Message-ID: <20200324233550.GA4521@yuki.lan> (raw)
In-Reply-To: <20200323224933.2613658-1-petr.vorel@gmail.com>
Hi!
> -#if !(__GLIBC_PREREQ(2, 10))
> static int
> accept4_01(int fd, struct sockaddr *sockaddr, socklen_t *addrlen, int flags)
> {
> -#if USE_SOCKETCALL
> long args[6];
>
> args[0] = fd;
> @@ -51,11 +51,7 @@ accept4_01(int fd, struct sockaddr *sockaddr, socklen_t *addrlen, int flags)
> args[3] = flags;
>
> return tst_syscall(__NR_socketcall, SYS_ACCEPT4, args);
> -#else
> - return tst_syscall(__NR_accept4, fd, sockaddr, addrlen, flags);
> -#endif
> }
> -#endif
This is very minor, however the function should be renamed to something
as socketcall_accept4().
Acked otherwise.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-03-24 23:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 22:49 [LTP] [PATCH 1/3] accept4: Use tst_variant Petr Vorel
2020-03-23 22:49 ` [LTP] [PATCH 2/3] accept4: Remove fallback definitions Petr Vorel
2020-03-24 23:36 ` Cyril Hrubis
2020-03-23 22:49 ` [LTP] [PATCH 3/3] travis: Update musl build Petr Vorel
2020-03-23 23:03 ` [LTP] [PATCH 1/3] accept4: Use tst_variant Petr Vorel
2020-03-24 6:53 ` Petr Vorel
2020-03-24 13:08 ` Li Wang
2020-03-24 23:35 ` Cyril Hrubis [this message]
2020-03-24 18:07 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324233550.GA4521@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox