From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Fix use after stack unwind in fzsync lib
Date: Wed, 25 Mar 2020 15:19:44 +0100 [thread overview]
Message-ID: <20200325141944.GA4021@yuki.lan> (raw)
In-Reply-To: <875zeszglp.fsf@our.domain.is.not.set>
Hi!
> > pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, NULL);
> > pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL);
> > - return t.func(t.arg);
> > + ret = t->func(t->arg);
> > + free(t);
>
> Why not use SAFE_FREE?
free() does not report errors, there is no such thing as SAFE_FREE()
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2020-03-25 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 10:37 [LTP] [PATCH] Fix use after stack unwind in fzsync lib Martin Doucha
2020-03-25 13:52 ` Richard Palethorpe
2020-03-25 14:19 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325141944.GA4021@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox