From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] Update syscalls/fsync02 to new API
Date: Thu, 26 Mar 2020 11:13:41 +0100 [thread overview]
Message-ID: <20200326101341.GA12365@dell5510> (raw)
In-Reply-To: <20200326111040.0bb5eb66@daedruan>
Hi Jozef, Martin,
> > > f_bavail = (stat_buf.f_bavail * stat_buf.f_frsize) /
> > > BLOCKSIZE;
> > Looks like the original test has another bug here. The correct
> > calculation is:
> > f_bavail = (stat_buf.f_bavail * stat_buf.f_bsize) / BLOCKSIZE;
> > f_frsize is the fragment size, a fraction of a real block used for
> > features like tail packing (stuffing multiple small files into the
> > same physical block). But file systems which don't support tail
> > packing generally have f_frsize == f_bsize.
> > Sorry for not noticing this earlier. Could you include a fix for this
> > in the second patch?
Martin, thanks for catching this.
> No problem Martin, I will fix it.
Thanks, Jozef. Waiting for v2.
Kind regards,
Petr
prev parent reply other threads:[~2020-03-26 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 13:38 [LTP] [PATCH 1/2] Update syscalls/fsync02 to new API Jozef Pupava
2020-03-26 8:37 ` Petr Vorel
2020-03-26 10:15 ` Jozef Pupava
2020-03-26 9:38 ` Martin Doucha
2020-03-26 10:10 ` Jozef Pupava
2020-03-26 10:13 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326101341.GA12365@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox