public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] LTP compilation broken with -fno-common
Date: Wed, 1 Apr 2020 11:58:22 +0200	[thread overview]
Message-ID: <20200401095822.GB23773@yuki.lan> (raw)
In-Reply-To: <e9ea8c2a-7c00-26a7-fb1a-0db9ae093620@suse.cz>

Hi!
> > We cannot move that definition into tst_test.c beacuse that would mean
> > that old API test would end up with multiple definitions one in the
> > corresponding test and one in the new library library code.
> 
> But we can move it a few lines up in tst_main.h so that it gets defined
> only together with the default main(), not in every .c file that
> includes tst_test.h.

The problem here is that gcc10 forbids variables in headers, moving it
anywhere int the header wouldn't help.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2020-04-01  9:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01  8:32 [LTP] LTP compilation broken with -fno-common Petr Vorel
2020-04-01  9:16 ` Richard Palethorpe
2020-04-01  9:39 ` Cyril Hrubis
2020-04-01  9:55   ` Martin Doucha
2020-04-01  9:58     ` Cyril Hrubis [this message]
2020-04-01 10:04       ` Martin Doucha
2020-04-01 10:15         ` Petr Vorel
2020-04-01 10:50         ` Cyril Hrubis
2020-04-01 11:42           ` Martin Doucha
2020-04-01 12:01             ` Cyril Hrubis
2020-04-01 10:14   ` Petr Vorel
2020-04-09  7:45   ` Petr Vorel
2020-04-09  9:18     ` Cyril Hrubis
2020-04-09 10:06     ` Li Wang
2020-04-15  7:00       ` Petr Vorel
2020-04-15 10:19       ` [LTP] hugemmap01 warnings with -i [was Re: LTP compilation broken with -fno-common] Petr Vorel
2020-04-16  9:13         ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200401095822.GB23773@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox