[LTP] LTP compilation broken with -fno-common

Petr Vorel
2020-04-09T07:45:05Z

Hi all,

> > /*
> > * This is a hack to make the testcases link without defining TCID
> > */
> > extern const char *TCID;

> This is not the original line, the original line is without the extern.

> Now this will not be easy to solve since the problem is:

> * All old style test define TCID in the test source that also implements main()

> * The test library uses that variable in various places

> * The variable definition is in the tst_test.h so that all new test also
> define TCID

> We cannot move that definition into tst_test.c beacuse that would mean
> that old API test would end up with multiple definitions one in the
> corresponding test and one in the new library library code.

> Maybe we can add it with a weak linker attribute. What about this patch:

> diff --git a/include/tst_test.h b/include/tst_test.h
> index 259d87d60..352e2cd64 100644
> --- a/include/tst_test.h
> +++ b/include/tst_test.h
> @@ -322,9 +322,7 @@ int main(int argc, char *argv[])

> #define TST_TEST_TCONF(message) \
> static struct tst_test test = { .tconf_msg = message } \
> -/*
> - * This is a hack to make the testcases link without defining TCID
> - */
> -const char *TCID;
> +
> +extern const char *TCID;

> #endif /* TST_TEST_H__ */
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 73827d472..4ce8cc301 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -32,6 +32,11 @@
> #include "old_device.h"
> #include "old_tmpdir.h"

> +/*
> + * Hack to get TCID defined in newlib tests
> + */
> +const char *TCID __attribute__((weak));
> +
> #define LINUX_GIT_URL "https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id="
> #define CVE_DB_URL "https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-"

> I guess that we can even drop the TCID extern definition from the tst_test.h
> header if the weak attribute works fine.

I'd be for adding this patch (both version works), Cyril, will you send it
to ML / push it?

I'd also be for adding -fno-common to Travis after this fix.

Kind regards,
Petr