[LTP] [PATCH v5 2/3] Add LVM support scripts

Cyril Hrubis
2020-04-14T14:08:32Z

Hi!
> >> generate_lvm_runfile.sh will be called near the end of install_ltp to
> >> generate system-specific runfile for LVM tests using the template.
> >> prepare_lvm.sh will be called in a separate OpenQA module right after
> >> boot_ltp. None of these helper scripts should be included in any runfile.
> >
> > So these are OpenQA specific scripts, I do not think that they belong to
> > LTP upstream unless we make then work with upstream LTP.
>
> These scripts have no dependencies on OpenQA and can be used to prepare
> LVM test environment under any harness, including manual testing. I've
> made some design choices to ensure compatibility with OpenQA but they're
> really meant as full replacement for testscripts/ltpfslvm.sh which has
> been in LTP since forever.

Sure but unless there is a glue script that actually makes the tests run
or at least a README it's kind of pointless.

I would really prefer if there was something that coulud execute these
tests in upstream by starting a single script, so that it's clear how
these script should be used in the first place.

--
Cyril Hrubis
chrubis@suse.cz