From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/8] lib: Fix linking error multiple TCID definitions with -fno-common
Date: Wed, 15 Apr 2020 11:30:38 +0200 [thread overview]
Message-ID: <20200415093038.GA12705@rei.lan> (raw)
In-Reply-To: <20200415092809.20240-2-pvorel@suse.cz>
Hi!
> +extern const char *TCID;
Do we really need this extern or can we remove it?
> #endif /* TST_TEST_H__ */
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index e502c2c1a..64cd3ac33 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -32,6 +32,11 @@
> #include "old_device.h"
> #include "old_tmpdir.h"
--
chrubis@suse.cz
next prev parent reply other threads:[~2020-04-15 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 9:28 [LTP] [RFC PATCH 0/8] Fix compilation with -fno-common (gcc-10) Petr Vorel
2020-04-15 9:28 ` [LTP] [RFC PATCH 1/8] lib: Fix linking error multiple TCID definitions with -fno-common Petr Vorel
2020-04-15 9:30 ` Cyril Hrubis [this message]
2020-04-15 9:49 ` Petr Vorel
2020-04-15 10:49 ` Cyril Hrubis
2020-04-15 11:08 ` Petr Vorel
2020-04-15 9:28 ` [LTP] [RFC PATCH 2/8] controllers: Simplify fullpath definition Petr Vorel
2020-04-15 9:28 ` [LTP] [RFC PATCH 3/8] controllers: Fix linking with -fno-common Petr Vorel
2020-04-15 9:28 ` [LTP] [RFC PATCH 4/8] kernel/mem: Fix linking error " Petr Vorel
2020-04-15 9:28 ` [LTP] [RFC PATCH 5/8] hugepage: " Petr Vorel
2020-04-15 9:28 ` [LTP] [RFC PATCH 6/8] hugetlb: " Petr Vorel
2020-04-15 9:28 ` [LTP] [RFC PATCH 7/8] realtime: " Petr Vorel
2020-04-15 9:28 ` [LTP] [RFC PATCH 8/8] travis: Build " Petr Vorel
2020-04-15 9:39 ` [LTP] [RFC PATCH 0/8] Fix compilation with -fno-common (gcc-10) Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415093038.GA12705@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox