From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 02/10] syscalls/ioctl:add common c file for loop ioctl
Date: Mon, 20 Apr 2020 15:01:40 +0200 [thread overview]
Message-ID: <20200420130140.GB11604@yuki.lan> (raw)
In-Reply-To: <48142e6b-8169-2934-e8b2-f71927cd62b0@cn.fujitsu.com>
Hi!
> +void tst_assert_file_str(const char *file, const int lineno, const char
> *path, const char *buf, const char *val)
> +{
> + char sys_val[1024];
> +
> + SAFE_FILE_LINES_SCANF(path, buf, sys_val);
We should call the file_lines_scanf() here and pass the filename and
lineno that this functions takes as parameter instead.
Also I'm not sure that it's a good idea to pass the fmt to this
function. I guess that it would be better to pass a prefix string such
as "foo=" and to append the "%s" in this function. That way we could
also encode the buffer length to the fmt string as well, in that case we
would append "%1024s".
> + if (!strcmp(val, sys_val)) {
> + tst_res_(file, lineno, TPASS, "%s %s field = %s", path,
> buf, sys_val);
> + return;
> + }
> +
> + tst_res_(file, lineno, TFAIL, "%s %s field != %s got %s", path,
> buf, val, sys_val);
> +}
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-04-20 13:01 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 15:06 [LTP] [PATCH v1 00/10] add loop ioctl test Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 01/10] lapi: Add a configure check and fallback for loop ioctl and flag Yang Xu
2020-04-03 11:44 ` Cyril Hrubis
2020-04-06 6:01 ` Yang Xu
2020-04-09 8:47 ` Martin Doucha
2020-04-09 10:09 ` Cyril Hrubis
2020-04-09 10:14 ` Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 02/10] syscalls/ioctl:add common c file for loop ioctl Yang Xu
2020-04-03 12:16 ` Cyril Hrubis
2020-04-09 2:42 ` Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 03/10] syscalls/ioctl_loop01: Add LO_FLAGS_AUTOCLEAR and LO_FLAGS_PARTSCAN test Yang Xu
2020-04-03 11:55 ` Cyril Hrubis
2020-04-06 6:27 ` Yang Xu
2020-04-09 6:10 ` Yang Xu
2020-04-09 7:55 ` Cyril Hrubis
2020-04-09 10:44 ` [LTP] [PATCH v2 01/10] lapi/loop.h: Add fallback for loop ioctl and flag Yang Xu
2020-04-09 10:44 ` [LTP] [PATCH v2 02/10] syscalls/ioctl:add common c file for loop ioctl Yang Xu
2020-04-17 15:10 ` Cyril Hrubis
2020-04-20 2:23 ` Yang Xu
2020-04-20 6:08 ` Yang Xu
2020-04-20 13:01 ` Cyril Hrubis [this message]
2020-04-21 6:19 ` Yang Xu
2020-04-21 8:55 ` Cyril Hrubis
2020-04-21 10:35 ` Yang Xu
2020-04-21 12:12 ` Cyril Hrubis
2020-04-22 3:12 ` Yang Xu
2020-04-20 12:55 ` Cyril Hrubis
2020-04-09 10:44 ` [LTP] [PATCH v2 03/10] syscalls/ioctl_loop01: Add LO_FLAGS_AUTOCLEAR and LO_FLAGS_PARTSCAN test Yang Xu
2020-04-09 10:44 ` [LTP] [PATCH v2 04/10] syscalls/ioctl_loop02: Add LO_FLAGS_READ_ONLY and LOOP_CHANGE_FD test Yang Xu
2020-04-09 10:44 ` [LTP] [PATCH v2 05/10] syscalls/ioctl_loop03: Add LOOP_CHANGE_FD test with WR mode Yang Xu
2020-04-17 15:12 ` Cyril Hrubis
2020-04-09 10:44 ` [LTP] [PATCH v2 06/10] syscalls/ioctl_loop04: Add LOOP_SET_CAPACITY ioctl test Yang Xu
2020-04-09 10:44 ` [LTP] [PATCH v2 07/10] syscalls/ioctl_loop05: Add LOOP_SET_DIRECT_IO " Yang Xu
2020-04-09 10:44 ` [LTP] [PATCH v2 08/10] syscalls/ioctl_loop06: Add LOOP_SET_BLOCK_SIZE error test Yang Xu
2020-04-22 13:57 ` Cyril Hrubis
2020-04-09 10:44 ` [LTP] [PATCH v2 09/10] syscalls/ioctl_loop07: Add dio with logic block size " Yang Xu
2020-04-22 13:58 ` Cyril Hrubis
2020-04-23 6:06 ` Yang Xu
2020-04-23 10:12 ` Yang Xu
2020-04-24 4:43 ` Yang Xu
2020-04-09 10:44 ` [LTP] [PATCH v2 10/10] syscalls/ioctl_loop08: Add LOOP_SET/GET_STATUS64 sizelimit field test Yang Xu
2020-04-28 15:44 ` Cyril Hrubis
2020-04-09 10:44 ` [LTP] [PATCH v2 00/10] add loop ioctl test Yang Xu
2020-04-09 10:50 ` [LTP] [PATCH v2 01/10] lapi/loop.h: Add fallback for loop ioctl and flag Yang Xu
2020-04-17 15:11 ` Cyril Hrubis
2020-04-27 1:24 ` [LTP] [PATCH v1 03/10] syscalls/ioctl_loop01: Add LO_FLAGS_AUTOCLEAR and LO_FLAGS_PARTSCAN test Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 04/10] syscalls/ioctl_loop02: Add LO_FLAGS_READ_ONLY and LOOP_CHANGE_FD test Yang Xu
2020-04-03 13:34 ` Cyril Hrubis
2020-04-06 7:24 ` Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 05/10] syscalls/ioctl_loop03: Add LOOP_CHANGE_FD test with WR mode Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 06/10] syscalls/ioctl_loop04: Add LOOP_SET_CAPACITY ioctl test Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 07/10] syscalls/ioctl_loop05: Add LOOP_SET_DIRECT_IO " Yang Xu
2020-04-03 16:44 ` Cyril Hrubis
2020-04-06 7:53 ` Yang Xu
2020-04-06 8:30 ` Cyril Hrubis
2020-04-02 15:06 ` [LTP] [PATCH v1 08/10] syscalls/ioctl_loop06: Add LOOP_SET_BLOCK_SIZE error test Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 09/10] syscalls/ioctl_loop07: Add dio with logic block size " Yang Xu
2020-04-02 15:06 ` [LTP] [PATCH v1 10/10] syscalls/ioctl_loop08: Add LOOP_SET/GET_STATUS64 sizelimit field test Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420130140.GB11604@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox