public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Purpose of clock_nanosleep2 tests ?
Date: Tue, 21 Apr 2020 11:44:22 +0200	[thread overview]
Message-ID: <20200421094422.GE6577@yuki.lan> (raw)
In-Reply-To: <20200421092616.lnktrr4e4pv7wemm@vireshk-i7>

Hi!
> > > While working on the time64 variants I stumbled upon
> > > testcases/kernel/syscalls/clock_nanosleep2/.
> > > 
> > > The commit  log says that we were trying to test clock_nanosleep2()
> > > syscall, which I am unable to find, but still this ends up calling the kernel
> > > variant directly for clock_nanosleep() only.
> > > 
> > > What am I missing ? Why is this stuff required ?
> > 
> > Hmm, I guess that there is no clock_nanosleep2() and the test is a
> > result of a confusion of some kind. Maybe the author just confused
> > clock_nanosleep(2) with clock_nanosleep2().
> > 
> > Looking at clock_nanosleep() tests, there does not seem to be a test
> > for ABSTIME so the best solution would be to move the test to
> > clock_nanosleep directory. What do you think?
> 
> clock_nanosleep03.c already tests ABSTIME. I think we can just drop
> clock_nanosleep2 directory completely. I will send a patch if that looks okay.

clock_nanosleep03 is testing that inside of a time namespace, I think
that there is still value of having the simpler test as well.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2020-04-21  9:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21  7:37 [LTP] Purpose of clock_nanosleep2 tests ? Viresh Kumar
2020-04-21  9:20 ` Cyril Hrubis
2020-04-21  9:26   ` Viresh Kumar
2020-04-21  9:44     ` Cyril Hrubis [this message]
2020-04-21  9:46       ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421094422.GE6577@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox