From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] net/sendfile01.sh: Rewrite into new API
Date: Tue, 21 Apr 2020 19:41:04 +0200 [thread overview]
Message-ID: <20200421174104.GA4344@dell5510> (raw)
In-Reply-To: <ec51559c-09e3-b518-f144-4246c68f1bd9@oracle.com>
Hi Alexey,
...
> > + tst_res TINFO "wait for the server to start"
> > + sleep 1
> It would be better to replace 'sleep' with a wait-loop and check that the
> port in the listen state there, e.g with ss -ltp | grep "$port.*testsf"
I'm sorry, I overlooked this. I'm sorry, merged without this.
I'll implement it separately.
Thanks for your review.
...
> > + diff $file $lfile > /dev/null
> > + ret=$?
> > + if [ $ret -eq 0 ]; then
> > + tst_res TPASS "coped file is the same as the original"
> > + elif [ $ret -gt 1 ]; then
> > + tst_brk TFAIL "cannot compare files"
> > + else
> > + tst_res TFAIL "the copied file differs from the original"
> EXPECT_PASS diff $lfile
Fixed.
Kind regards,
Petr
prev parent reply other threads:[~2020-04-21 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 10:45 [LTP] [PATCH 1/2] net: Add $TST_NET_DATAROOT variable Petr Vorel
2020-04-16 10:45 ` [LTP] [PATCH 2/2] net/sendfile01.sh: Rewrite into new API Petr Vorel
2020-04-16 11:00 ` Petr Vorel
2020-04-21 12:58 ` Alexey Kodanev
2020-04-21 17:41 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421174104.GA4344@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox