ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V5 5/5] syscalls/clock_adjtime: Add support for time64 tests
Date: Mon, 27 Apr 2020 16:15:21 +0200	[thread overview]
Message-ID: <20200427141520.GC7661@rei> (raw)
In-Reply-To: <c4bf1e2c7699a8fe2d05ab498495646f9d41ce44.1587712683.git.viresh.kumar@linaro.org>

Hi!
I've cleaned up the code and pushed, thanks.

Fixed things such as:

* Macros should be uppercase, otherwise it's confusing

* All local variables has to be passed to macros as parameters
  this one is confusing as hell

* No variables and parameters stating with underscore, unless
  we defined fallback for kernel types these are reserved for
  kernel/libc

* The tst_get_bad_addr() allocates a page for each call, so I have moved
  it to setup

* etc...

-- 
chrubis@suse.cz

  reply	other threads:[~2020-04-27 14:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a143f48ffeec14739d35c07dfb95f237981a322d.1587712683.git.viresh.kumar@linaro.org>
2020-04-22  5:37 ` [LTP] [PATCH V4 0/5] syscalls/clock_*(): Add support for time64 variants Viresh Kumar
2020-04-22  5:37   ` [LTP] [PATCH V4 1/5] syscalls/clock_gettime: Add support for time64 tests Viresh Kumar
2020-04-23 13:50     ` Cyril Hrubis
2020-04-24  7:19       ` Viresh Kumar
2020-04-24 15:02         ` Cyril Hrubis
2020-04-22  5:37   ` [LTP] [PATCH V4 2/5] syscalls/clock_settime: " Viresh Kumar
2020-04-23 15:08     ` Cyril Hrubis
2020-04-22  5:37   ` [LTP] [PATCH V4 3/5] syscalls/clock_getres: " Viresh Kumar
2020-04-22  5:37   ` [LTP] [PATCH V4 4/5] syscalls/clock_nanosleep: " Viresh Kumar
2020-04-22  5:37   ` [LTP] [PATCH V4 5/5] syscalls/clock_adjtime: " Viresh Kumar
2020-04-24  7:18   ` [LTP] [PATCH V5 3/5] syscalls/clock_getres: " Viresh Kumar
2020-04-24  7:18     ` [LTP] [PATCH V5 4/5] syscalls/clock_nanosleep: " Viresh Kumar
2020-04-24  7:18     ` [LTP] [PATCH V5 5/5] syscalls/clock_adjtime: " Viresh Kumar
2020-04-27 14:15       ` Cyril Hrubis [this message]
2020-04-28  4:30         ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427141520.GC7661@rei \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).