From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/4] syscalls/fanotify: New test for FAN_MODIFY_DIR
Date: Mon, 27 Apr 2020 18:49:02 +0200 [thread overview]
Message-ID: <20200427164902.GA4544@dell5510> (raw)
In-Reply-To: <20200421065002.12417-5-amir73il@gmail.com>
Hi Amir,
thank you for this patchset!
...
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify16.c b/testcases/kernel/syscalls/fanotify/fanotify16.c
...
> + } else if (memcmp(&event_fid->fsid, &expected->fid->fsid,
> + sizeof(event_fid->fsid)) != 0) {
> + tst_res(TFAIL,
> + "got event: mask=%llx pid=%u fd=%d name='%s' "
> + "len=%d info_type=%d info_len=%d fh_len=%d "
> + "fsid=%x.%x (expected %x.%x)",
> + (unsigned long long)event->mask,
> + (unsigned)event->pid, event->fd, filename,
> + event->event_len, info_type,
> + event_fid->hdr.len, fhlen,
> + event_fid->fsid.val[0], event_fid->fsid.val[1],
This needs to be:
+ FSID_VAL_MEMBER(event_fid->fsid, 0),
+ FSID_VAL_MEMBER(event_fid->fsid, 1),
FSID_VAL_MEMBER() is a wrapper struct fanotify_event_info_fid, needed to fix
build on musl (and it shouldn't be used for struct event_t).
https://travis-ci.org/github/pevik/ltp/jobs/680149701
Also I got problems on FUSE:
safe_macros.c:754: INFO: Trying FUSE...
tst_test.c:1244: INFO: Timeout per run is 0h 05m 00s
fanotify16.c:112: INFO: Test #0: FAN_REPORT_FID with mark type: FAN_MARK_FILESYSTEM
fanotify16.c:138: BROK: fanotify_mark (3, FAN_MARK_ADD | FAN_MARK_FILESYSTEM, FAN_DIR_MODIFY, AT_FDCWD, 'fs_mnt') failed: ENODEV (19)
tst_device.c:373: INFO: umount('fs_mnt') failed with EBUSY, try 1...
tst_device.c:377: INFO: Likely gvfsd-trash is probing newly mounted fs, kill it to speed up tests.
Skipping FUSE fixes it:
.dev_fs_flags = TST_FS_SKIP_FUSE,
Kind regards,
Petr
next prev parent reply other threads:[~2020-04-27 16:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 6:49 [LTP] [PATCH 0/4] fanotify ltp tests for v5.7-rc1 Amir Goldstein
2020-04-21 6:49 ` [LTP] [PATCH 1/4] syscalls/fanotify09: Check merging of events on directories Amir Goldstein
2020-04-27 17:27 ` Petr Vorel
2020-05-01 7:17 ` Matthew Bobrowski
2020-05-01 9:05 ` Amir Goldstein
2020-05-01 9:46 ` Matthew Bobrowski
2020-04-21 6:50 ` [LTP] [PATCH 2/4] syscalls/fanotify15: Minor corrections Amir Goldstein
2020-04-27 19:30 ` Petr Vorel
2020-04-29 15:08 ` Cyril Hrubis
2020-05-01 8:09 ` Matthew Bobrowski
2020-04-21 6:50 ` [LTP] [PATCH 3/4] syscalls/fanotify15: Add a test case for inode marks Amir Goldstein
2020-04-27 19:43 ` Petr Vorel
2020-04-28 9:20 ` Petr Vorel
2020-04-29 15:28 ` Cyril Hrubis
2020-05-02 7:09 ` Matthew Bobrowski
2020-05-02 13:17 ` Amir Goldstein
2020-04-21 6:50 ` [LTP] [PATCH 4/4] syscalls/fanotify: New test for FAN_MODIFY_DIR Amir Goldstein
2020-04-27 16:49 ` Petr Vorel [this message]
2020-04-28 9:22 ` Petr Vorel
2020-04-28 9:51 ` Amir Goldstein
2020-04-29 16:02 ` Cyril Hrubis
2020-05-02 9:39 ` Matthew Bobrowski
2020-05-02 14:58 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427164902.GA4544@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox